Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FallibleTask::is_finished() #34

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Add FallibleTask::is_finished() #34

merged 1 commit into from
Oct 3, 2022

Conversation

mystenmark
Copy link
Contributor

I'm unsure if there is a reason why this didn't exist already, but it seems straightforward to me.

notgull
notgull approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@mystor Is there any reason why you didn't add this method while you were writing #21?

@taiki-e
Copy link
Collaborator

taiki-e commented Oct 3, 2022

Is there any reason why you didn't add this method while you were writing #21?

This is because FallibleTask is added in 4.1.0 (3706c1e) and Task::is_finished is added in 4.2.0 (67d2a17).

@taiki-e taiki-e merged commit 230b0a4 into smol-rs:master Oct 3, 2022
@taiki-e
Copy link
Collaborator

taiki-e commented Oct 3, 2022

Thanks!

@mystor
Copy link
Contributor

mystor commented Oct 4, 2022

Yup, it just didn't exist at the time :-)

@notgull notgull mentioned this pull request Mar 24, 2023
Merged
notgull added a commit that referenced this pull request Mar 24, 2023
@notgull
v4.4.0 (#45)
eeee41d 
- Ensure that the allocation doesn't exceed `isize::MAX` (#32)
- Add `FallibleTask::is_finished()` (#34)
- Add a metadata generic parameter to tasks (#33)
- Add panic propagation to tasks (#37)
- Add a way to tell if the task was woken while running from the schedule function (#42)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notgull notgull notgull approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mystenmark @taiki-e @mystor @notgull