Use @aws-crypto/sha256-js for hasher in RN #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srchase
approved these changes
Mar 13, 2020
AllanZhengYP
added a commit
to aws/aws-sdk-js-v3
that referenced
this pull request
Mar 13, 2020
The @aws-crypto/sha256-browser package doesn't work properly in ReactNative. So we use replace it will pure JS hasher(@aws-crypto/sha256-js) instead. Codegen for smithy-lang/smithy-typescript#144
AllanZhengYP
added a commit
to AllanZhengYP/aws-sdk-js-v3
that referenced
this pull request
Mar 20, 2020
The @aws-crypto/sha256-browser package doesn't work properly in ReactNative. So we use replace it will pure JS hasher(@aws-crypto/sha256-js) instead. Codegen for smithy-lang/smithy-typescript#144
trivikr
pushed a commit
to trivikr/aws-sdk-js-v3
that referenced
this pull request
Mar 20, 2020
The @aws-crypto/sha256-browser package doesn't work properly in ReactNative. So we use replace it will pure JS hasher(@aws-crypto/sha256-js) instead. Codegen for smithy-lang/smithy-typescript#144
trivikr
pushed a commit
to trivikr/aws-sdk-js-v3
that referenced
this pull request
Mar 24, 2020
The @aws-crypto/sha256-browser package doesn't work properly in ReactNative. So we use replace it will pure JS hasher(@aws-crypto/sha256-js) instead. Codegen for smithy-lang/smithy-typescript#144
trivikr
pushed a commit
to trivikr/aws-sdk-js-v3
that referenced
this pull request
Mar 24, 2020
The @aws-crypto/sha256-browser package doesn't work properly in ReactNative. So we use replace it will pure JS hasher(@aws-crypto/sha256-js) instead. Codegen for smithy-lang/smithy-typescript#144
srchase
pushed a commit
to srchase/smithy-typescript
that referenced
this pull request
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/aws-sdk-js-v3#929
Description of changes:
The
@aws-crypto/sha256-browserpackage doesn't work properly in ReactNative. So we use replace it will pure JS hasher(@aws-crypto/sha256-js) instead.Codegen PR: aws/aws-sdk-js-v3#998
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.