empty string in ruby is not falsy, adding empty? check to only add tag dimension if it is present

[taimoordev]

This PR is opened against this issue

Where the check if process["tag"] is returning true in case of empty string, which caused the issue for aws-sdk-cloudwatch library

[i7an]

Is it possible that process["tag"] is nil?

if process["tag"] && !process["tag"].empty?

(Please keep in mind I'm a random dev and not the repository maintainer.)

[taimoordev]

No, for those apps which are Rails based
Yes, for those apps which are only Ruby based

[FrancescaRodricks]

I've run into the same error. Can this be merged in please

[sj26]

Nice find, thanks!

[sj26]

Ah, now this introduced another error:

  2) Sidekiq::CloudWatchMetrics Publisher #publish with lots of queues publishes sidekiq metrics to cloudwatch in batches of 20
     Failure/Error: unless process["tag"].empty?

     NoMethodError:
       undefined method `empty?' for nil:NilClass
     # ./lib/sidekiq/cloudwatchmetrics.rb:192:in `block in publish'
     # ./lib/sidekiq/cloudwatchmetrics.rb:186:in `each'
     # ./lib/sidekiq/cloudwatchmetrics.rb:186:in `publish'
     # ./spec/sidekiq/cloudwatchmetrics_spec.rb:216:in `block (6 levels) in <top (required)>'
     # ./vendor/bundle/ruby/3.0.0/gems/timecop-0.9.10/lib/timecop/timecop.rb:225:in `travel'
     # ./vendor/bundle/ruby/3.0.0/gems/timecop-0.9.10/lib/timecop/timecop.rb:155:in `send_travel'
     # ./vendor/bundle/ruby/3.0.0/gems/timecop-0.9.10/lib/timecop/timecop.rb:58:in `freeze'
     # ./spec/sidekiq/cloudwatchmetrics_spec.rb:215:in `block (5 levels) in <top (required)>'