Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scalanative + utest - specs2 #199

Merged
merged 10 commits into from
Mar 11, 2019
Merged

Conversation

francisdb
Copy link
Contributor

@francisdb francisdb commented Feb 27, 2019

fixes #198

This PR

  • removes specs2 in favor of utest
  • adds scala native build

@francisdb
Copy link
Contributor Author

I wonder what is causing this

[info] Tests: 10, Passed: 10, Failed: 0
[trace] Stack trace suppressed: run last parboiledCoreNative/nativetest:nativeLink for the full output.
[error] (parboiledCoreNative/nativetest:nativeLink) java.nio.file.ClosedFileSystemException
[error] Total time: 14 s, completed Feb 28, 2019 9:06:36 AM
> last parboiledCoreNative/nativetest:nativeLink
java.nio.file.ClosedFileSystemException
	at com.sun.nio.zipfs.ZipFileSystem.ensureOpen(ZipFileSystem.java:1084)
	at com.sun.nio.zipfs.ZipFileSystem.newByteChannel(ZipFileSystem.java:633)
	at com.sun.nio.zipfs.ZipPath.newByteChannel(ZipPath.java:739)
	at com.sun.nio.zipfs.ZipFileSystemProvider.newByteChannel(ZipFileSystemProvider.java:255)
	at java.nio.file.Files.newByteChannel(Files.java:361)
	at java.nio.file.Files.newByteChannel(Files.java:407)
	at java.nio.file.Files.readAllBytes(Files.java:3152)
	at scala.scalanative.io.VirtualDirectory$NioDirectory$class.read(VirtualDirectory.scala:72)
	at scala.scalanative.io.VirtualDirectory$JarDirectory.read(VirtualDirectory.scala:97)
	at scala.scalanative.linker.ClassPath$Impl$$anonfun$2$$anonfun$apply$1.apply(ClassPath.scala:41)
	at scala.scalanative.linker.ClassPath$Impl$$anonfun$2$$anonfun$apply$1.apply(ClassPath.scala:41)
	at scala.scalanative.nir.serialization.BinaryDeserializer.scala$scalanative$nir$serialization$BinaryDeserializer$$buffer$lzycompute(BinaryDeserializer.scala:12)
	at scala.scalanative.nir.serialization.BinaryDeserializer.scala$scalanative$nir$serialization$BinaryDeserializer$$buffer(BinaryDeserializer.scala:12)
	at scala.scalanative.nir.serialization.BinaryDeserializer.header$lzycompute(BinaryDeserializer.scala:16)
	at scala.scalanative.nir.serialization.BinaryDeserializer.header(BinaryDeserializer.scala:15)
	at scala.scalanative.nir.serialization.BinaryDeserializer.deserialize(BinaryDeserializer.scala:55)
	at scala.scalanative.linker.ClassPath$Impl$$anonfun$load$1.apply(ClassPath.scala:52)
	at scala.scalanative.linker.ClassPath$Impl$$anonfun$load$1.apply(ClassPath.scala:51)
	at scala.Option.flatMap(Option.scala:170)
	at scala.scalanative.linker.ClassPath$Impl.load(ClassPath.scala:51)
	at scala.scalanative.linker.Linker$Impl$$anonfun$link$1$$anonfun$load$1$1.applyOrElse(Linker.scala:45)
	at scala.scalanative.linker.Linker$Impl$$anonfun$link$1$$anonfun$load$1$1.applyOrElse(Linker.scala:43)
	at scala.runtime.AbstractPartialFunction.apply(AbstractPartialFunction.scala:33)
	at scala.collection.TraversableOnce$$anonfun$collectFirst$1.apply(TraversableOnce.scala:133)
	at scala.collection.TraversableOnce$$anonfun$collectFirst$1.apply(TraversableOnce.scala:131)
	at scala.collection.Iterator$class.foreach(Iterator.scala:727)
	at scala.collection.AbstractIterator.foreach(Iterator.scala:1157)
	at scala.collection.TraversableOnce$class.collectFirst(TraversableOnce.scala:131)
	at scala.collection.AbstractTraversable.collectFirst(Traversable.scala:105)
	at scala.scalanative.linker.Linker$Impl$$anonfun$link$1.load$1(Linker.scala:43)
	at scala.scalanative.linker.Linker$Impl$$anonfun$link$1.processDirect$1(Linker.scala:54)
	at scala.scalanative.linker.Linker$Impl$$anonfun$link$1.apply(Linker.scala:135)
	at scala.scalanative.linker.Linker$Impl$$anonfun$link$1.apply(Linker.scala:28)
	at scala.scalanative.util.Scope$.apply(Scope.scala:30)
	at scala.scalanative.linker.Linker$Impl.link(Linker.scala:28)
	at scala.scalanative.build.ScalaNative$$anonfun$link$1.apply(ScalaNative.scala:27)
	at scala.scalanative.build.ScalaNative$$anonfun$link$1.apply(ScalaNative.scala:16)
	at scala.scalanative.build.Logger$class.time(Logger.scala:32)
	at scala.scalanative.build.Logger$$anon$2.time(Logger.scala:66)
	at scala.scalanative.build.ScalaNative$.link(ScalaNative.scala:16)
	at scala.scalanative.build.Build$.build(Build.scala:54)
	at scala.scalanative.sbtplugin.ScalaNativePluginInternal$$anonfun$scalaNativeConfigSettings$5$$anonfun$apply$7.apply(ScalaNativePluginInternal.scala:135)
	at scala.scalanative.sbtplugin.ScalaNativePluginInternal$$anonfun$scalaNativeConfigSettings$5$$anonfun$apply$7.apply(ScalaNativePluginInternal.scala:135)
	at scala.scalanative.sbtplugin.ScalaNativePluginInternal$.scala$scalanative$sbtplugin$ScalaNativePluginInternal$$interceptBuildException(ScalaNativePluginInternal.scala:210)
	at scala.scalanative.sbtplugin.ScalaNativePluginInternal$$anonfun$scalaNativeConfigSettings$5.apply(ScalaNativePluginInternal.scala:135)
	at scala.scalanative.sbtplugin.ScalaNativePluginInternal$$anonfun$scalaNativeConfigSettings$5.apply(ScalaNativePluginInternal.scala:130)
	at scala.Function1$$anonfun$compose$1.apply(Function1.scala:47)
	at sbt.$tilde$greater$$anonfun$$u2219$1.apply(TypeFunctions.scala:40)
	at sbt.std.Transform$$anon$4.work(System.scala:63)
	at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:228)
	at sbt.Execute$$anonfun$submit$1$$anonfun$apply$1.apply(Execute.scala:228)
	at sbt.ErrorHandling$.wideConvert(ErrorHandling.scala:17)
	at sbt.Execute.work(Execute.scala:237)
	at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:228)
	at sbt.Execute$$anonfun$submit$1.apply(Execute.scala:228)
	at sbt.ConcurrentRestrictions$$anon$4$$anonfun$1.apply(ConcurrentRestrictions.scala:159)
	at sbt.CompletionService$$anon$2.call(CompletionService.scala:28)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)

@francisdb francisdb changed the title WIP scalanative + utest - specs2 scalanative + utest - specs2 Feb 28, 2019
@francisdb
Copy link
Contributor Author

Should be ready for merging/squashing, depending on the release process some extra things will need to be added as the native modules are not aggregated by default

Copy link
Owner

@sirthias sirthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM!
Thank you, for all your work here, @francisdb!

In addition to the idea regarding the - collision I only have the one additional comment, that in some cases utest's ==> might be a little bit more readable than the assert(...) style, but ultimately it doesn't really matter, which style we use...

@francisdb
Copy link
Contributor Author

@sirthias anything that remains for this to be merged?

@sirthias
Copy link
Owner

Sorry, @francisdb, I didn't see that you pushed more stuff.
Looks good now.
Thank you again!

@sirthias sirthias merged commit 809cfbd into sirthias:release-2.1 Mar 11, 2019
@francisdb francisdb deleted the scalanative branch March 11, 2019 12:38
@francisdb francisdb restored the scalanative branch March 11, 2019 12:44
@francisdb
Copy link
Contributor Author

@sirthias hmm, looks like I should have squashed first :-s

@sirthias
Copy link
Owner

Ah, yeah.
Well, don't worry about it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scala-native support
2 participants