-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scalanative + utest - specs2 #199
Conversation
I wonder what is causing this
|
Should be ready for merging/squashing, depending on the release process some extra things will need to be added as the native modules are not aggregated by default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM!
Thank you, for all your work here, @francisdb!
In addition to the idea regarding the -
collision I only have the one additional comment, that in some cases utest's ==>
might be a little bit more readable than the assert(...)
style, but ultimately it doesn't really matter, which style we use...
@sirthias anything that remains for this to be merged? |
Sorry, @francisdb, I didn't see that you pushed more stuff. |
@sirthias hmm, looks like I should have squashed first :-s |
Ah, yeah. |
fixes #198
This PR