Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add card social comment component #70

Merged
merged 5 commits into from
Oct 24, 2023
Merged

Add card social comment component #70

merged 5 commits into from
Oct 24, 2023

Conversation

Tlezip
Copy link
Contributor

@Tlezip Tlezip commented Oct 22, 2023 •
edited by siriwatknp
Loading

closes #55

Details

  • Creating CardSocialComment component

Light mode
image

Dark mode
image

Expected result (Design)
image

@siriwatknp
Copy link
Owner

Results
Build Results https://www.chromatic.com/build?appId=64e95d8f1f548945b1225cb8&number=49
Storybook Preview https://64e95d8f1f548945b1225cb8-ukabmrkryh.chromatic.com/
Component Count 50

@siriwatknp
Copy link
Owner

Results
Build Results https://www.chromatic.com/build?appId=64e95d8f1f548945b1225cb8&number=50
Storybook Preview https://64e95d8f1f548945b1225cb8-nsdltnylow.chromatic.com/
Component Count 50

siriwatknp
siriwatknp reviewed Oct 23, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
siriwatknp
siriwatknp requested changes Oct 23, 2023
View reviewed changes
Copy link
Owner

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Overall Looks great. Please remove the icon dependencies and use Joy UI SvgIcon with plain svg instead

@siriwatknp
Copy link
Owner

@all-contributors please add @Tlezip for code.

@allcontributors allcontributors bot mentioned this pull request Oct 23, 2023
Merged
@allcontributors
Copy link
Contributor

@siriwatknp

I've put up a pull request to add @Tlezip! 🎉

@Tlezip
- use pure svg tag for icon
90d27e1 
- remove unnecessary @mui/icons-material, @mui/material
- add github username
- use const assertion instead of type casting
- change name, time position
@siriwatknp
Copy link
Owner

Results
Build Results https://www.chromatic.com/build?appId=64e95d8f1f548945b1225cb8&number=55
Storybook Preview https://64e95d8f1f548945b1225cb8-pyfetvahbb.chromatic.com/
Component Count 52

@Tlezip
Copy link
Contributor Author

Tlezip commented Oct 23, 2023

@siriwatknp I've fixed the comments, please help to review them again.
Also, the current implementation doesn't match perfectly with the design. Please tell me if we want to adjust it.

@siriwatknp
Copy link
Owner

Results
Build Results https://www.chromatic.com/build?appId=64e95d8f1f548945b1225cb8&number=56
Storybook Preview https://64e95d8f1f548945b1225cb8-jlckgqpndm.chromatic.com/
Component Count 52

@siriwatknp
Copy link
Owner

Results
Build Results https://www.chromatic.com/build?appId=64e95d8f1f548945b1225cb8&number=57
Storybook Preview https://64e95d8f1f548945b1225cb8-tmgofneokl.chromatic.com/
Component Count 52

@siriwatknp siriwatknp merged commit b220704 into siriwatknp:main Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request] card-social-comment
2 participants
@Tlezip @siriwatknp