Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-array-method-this-argument: Fix false positives #1386

Merged
merged 4 commits into from
Jun 30, 2021
Merged

no-array-method-this-argument: Fix false positives #1386

merged 4 commits into from
Jun 30, 2021

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Jun 30, 2021 •
edited
Loading

  • Ignore methods from lodash, underscore, jQuery, and React
  • Ignore cases that first argument is not a function

Fixes #1385

@fisker fisker mentioned this pull request Jun 30, 2021
Closed
@fisker fisker changed the title no-array-method-this-argument: Ignore methods from lodash, underscore, jQuery, and React no-array-method-this-argument: Fix false positives Jun 30, 2021
@sindresorhus sindresorhus merged commit d364d67 into sindresorhus:main Jun 30, 2021
@fisker fisker deleted the no-array-method-this-argument-ignore branch June 30, 2021 10:07
@JounQin
Copy link
Contributor

JounQin commented Oct 19, 2021

Can you add ramda too? @fisker

@fisker
Copy link
Collaborator Author

fisker commented Oct 20, 2021

Why don't you send a PR, add them to the list, I think we can accept it.

@JounQin JounQin mentioned this pull request Oct 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[no-array-method-this-argument] - false positives, lodash map, foreach, filter and React.Chidlren.map
3 participants
@fisker @JounQin @sindresorhus