DEP PHP Support in CMS5 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
sabina-talipova
force-pushed
the
pulls/3/upgrade-cms5
branch
2 times, most recently
from
52be507 to
20c5eda
Compare
|
Tests passed |
sabina-talipova
force-pushed
the
pulls/3/upgrade-cms5
branch
from
20c5eda to
2cc1fcd
Compare
emteknetnz
requested changes
Dec 21, 2022
| @@ -72,7 +72,7 @@ public function numRecords() | |||
| return $c; | |||
| } | |||
|
|
|||
| public function nextRecord() | |||
| public function getIterator() | |||
There was a problem hiding this comment.
Could you add the #[\ReturnTypeWillChange] above this method e.g. /~https://github.com/silverstripe/silverstripe-framework/blob/5/src/ORM/Connect/MySQLQuery.php#L48
sabina-talipova
force-pushed
the
pulls/3/upgrade-cms5
branch
from
2cc1fcd to
b00e7aa
Compare
emteknetnz
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue