Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Check value is not NULL #88

Conversation

sabina-talipova
Copy link
Contributor

Description

FormSpamProtectionExtension::get_protector($options = null) returns null if $options is null or $options['protector'] doesn't exist and 'default_spam_protector' config don't set up.
Additional check for NULL was added before invoke SpamProtector class methods.

Parent issue

@sabina-talipova sabina-talipova force-pushed the pulls/3/fix-invoke-method-on-null branch 2 times, most recently from fd15915 to 15d53ee Compare January 16, 2023 19:26
@sabina-talipova sabina-talipova force-pushed the pulls/3/fix-invoke-method-on-null branch from 15d53ee to 2a55708 Compare January 16, 2023 19:30
Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-rainville maxime-rainville merged commit 1c99bc8 into silverstripe:3 Jan 16, 2023
@maxime-rainville maxime-rainville deleted the pulls/3/fix-invoke-method-on-null branch January 16, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants