SiteTree won't write new versions if only a field named 'Status' is changed

[kinglozzer]

Please don’t ask how much time I wasted because of this bug 😭😂

<?php

class MyPage extends Page
{
    private static $db = [
        'Status' => 'Varchar(255)'
    ];

    public function getCMSFields()
    {
        $this->beforeUpdateCMSFields(function (FieldList $fields) {
            $fields->addFieldToTab('Root.Main', TextField::create('Status'));
        });

        return parent::getCMSFields();
    }

    public function onAfterPublish()
    {
        die('you will never get this, a-la-la-la-la');
    }
}

Make changes to the value of status, onAfterPublish() won’t be called. The only time it’ll be called is if you also make a change to another field’s value as well. There are other issues this bug causes, but this is the easiest to reproduce.

The cause is this line:

silverstripe-cms/code/Model/SiteTree.php

Line 1588 in 8a44071

$fieldsIgnoredByVersioning = array('HasBrokenLink', 'Status', 'HasBrokenFile', 'ToDo', 'VersionID', 'SaveCount');

.

I’m not sure if we should just remove that whole code block, but at the very least we should remove Status from the array as it’s no longer a field on SiteTree (it hasn’t been since 2.4). We should also remove ToDo, VersionID and SaveCount.

PRs

• FIX: Remove legacy fields which prevent page publish (fixes #2455) #3002

[michalkleiner]

How much time did you waste?

[kinglozzer]

$hoursWasted += 1;

PR: #3002

[GuySartorelli]

PR merged. This will be automatically tagged by GitHub Actions.

[madmatt]

var_dump($hoursWasted);

[kinglozzer]

int(probably 1 hour for each year since i opened this 🤦‍♂️)