DEP PHP Support in CMS5 #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
emteknetnz
requested changes
Dec 18, 2022
composer.json
Outdated
| "silverstripe/cms": "^5", | ||
| "silverstripe/admin": "^2", | ||
| "silverstripe/vendor-plugin": "^2", | ||
| "symbiote/silverstripe-gridfieldextensions": "^3.5", |
There was a problem hiding this comment.
Suggested change
| "symbiote/silverstripe-gridfieldextensions": "^3.5", | |
| "symbiote/silverstripe-gridfieldextensions": "^4", |
sabina-talipova
force-pushed
the
pulls/2/upgrade-cms5
branch
2 times, most recently
from
11f8ae1 to
395ecc6
Compare
sabina-talipova
force-pushed
the
pulls/2/upgrade-cms5
branch
2 times, most recently
from
4fe7065 to
a683f80
Compare
|
Created new issue for failed Behat tests #280 |
maxime-rainville
requested changes
Jan 12, 2023
| @@ -24,15 +22,17 @@ protected function setUp(): void | |||
|
|
|||
| public function testGetSchemaFromPageUrl() | |||
| { | |||
| $response = $this->get('animal-centers/schema'); | |||
| $this->logInWithPermission('ADMIN'); | |||
There was a problem hiding this comment.
Suggested change
| $this->logInWithPermission('ADMIN'); | |
| $this->logInWithPermission('VIEW_DRAFT_CONTENT'); |
|
|
||
| $this->assertSame(200, $response->getStatusCode()); | ||
| $this->assertJson($response->getBody()); | ||
| } | ||
|
|
||
| public function testGetSchemaFromPageSubUrl() | ||
| { | ||
| $response = $this->get('animal-centers/view/123/schema'); | ||
| $this->logInWithPermission('ADMIN'); |
There was a problem hiding this comment.
Suggested change
| $this->logInWithPermission('ADMIN'); | |
| $this->logInWithPermission('VIEW_DRAFT_CONTENT'); |
sabina-talipova
force-pushed
the
pulls/2/upgrade-cms5
branch
from
a683f80 to
1d70aa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue