PKCS11 signing support #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kieran Miller <kieran.miller@garantir.io>
Signed-off-by: Kieran Miller <kieran.miller@garantir.io>
garantir-km
force-pushed
the
pkcs11-support
branch
from
035250b to
c4b18f7
Compare
Signed-off-by: Kieran Miller <kieran.miller@garantir.io>
hectorj2f
reviewed
Nov 2, 2021
There was a problem hiding this comment.
@garantir-km how feasible would it be to add some tests using SoftHSM like done here /~https://github.com/miekg/pkcs11/blob/master/parallel_test.go ?
|
@hectorj2f I think I can add some tests to validate both the PKCS11 URI implementation and the PKCS11 implementation of the Signer interface. |
Added PKCS11 tests. Signed-off-by: Kieran Miller <kieran.miller@garantir.io>
Signed-off-by: Kieran Miller <kieran.miller@garantir.io>
Signed-off-by: Kieran Miller <kieran.miller@garantir.io>
Signed-off-by: Kieran Miller <kieran.miller@garantir.io>
Signed-off-by: Kieran Miller <kieran.miller@garantir.io>
|
@hectorj2f hopefully all workflows will pass now |
|
I was successfully able to test against SoftHSM v2.5.0 with RSA. |
|
One nit about doing the URI switching in a slightly lower level, I think that will reduce duplication in the verify and verify attestation commands as well. |
hectorj2f
approved these changes
Nov 5, 2021
dlorenc
reviewed
Nov 5, 2021
Signed-off-by: Kieran Miller <kieran.miller@garantir.io>
|
Thank you! Lgtm when tests pass! |
dlorenc
approved these changes
Nov 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR provides support for PKCS11 tokens. The implementation relies on PKCS11 URIs, which makes it possible to use PKCS11 backed keys without adding extra flags and logic to cosign.
The PR also provides a new tool called
pkcs11-toolwhich allows for retrieval of the PKCS11 URIs for keys in a particular token.Ticket Link
This PR is in relation with #396.
Release Notes
Signed-off-by: Kieran Miller kieran.miller@garantir.io