Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: warnings on admissionregistration version #581

Merged
merged 3 commits into from
Aug 27, 2021
Merged

fix: warnings on admissionregistration version #581

merged 3 commits into from
Aug 27, 2021

Conversation

hectorj2f
Copy link
Contributor

Signed-off-by: Hector Fernandez hectorf@vmware.com

When installing the helm chart of cosigned, we are seeing some warnings due to the version of the admissionregistration object.

W0826 21:57:01.000200   13246 warnings.go:70] admissionregistration.k8s.io/v1beta1 ValidatingWebhookConfiguration is deprecated in v1.16+, unavailable in v1.22+; use admissionregistration.k8s.io/v1 ValidatingWebhookConfiguration
W0826 21:57:01.219700   13246 warnings.go:70] admissionregistration.k8s.io/v1beta1 ValidatingWebhookConfiguration is deprecated in v1.16+, unavailable in v1.22+; use admissionregistration.k8s.io/v1 ValidatingWebhookConfiguration
NAME: cosigned
LAST DEPLOYED: Thu Aug 26 21:57:00 2021
NAMESPACE: cosigned
STATUS: deployed
REVISION: 1
TEST SUITE: None

fix: warnings on admissionregistration version
2c3c5b4 
Signed-off-by: Hector Fernandez <hectorf@vmware.com>
@dlorenc
Copy link
Member

dlorenc commented Aug 26, 2021

Any idea what the lint issue is?

@hectorj2f
Copy link
Contributor Author

Let me check it!

fix: bump Chart version
4abfc15 
Signed-off-by: Hector Fernandez <hectorf@vmware.com>
@hectorj2f
Copy link
Contributor Author

Helm linting required to bump the Chart version whenever you change files of the Chart.

@cpanato cpanato added this to the v1.2.0 milestone Aug 27, 2021
developer-guy
developer-guy approved these changes Aug 27, 2021
View reviewed changes
Copy link
Member

@developer-guy developer-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤝 🥳

@hectorj2f
chore: limit admission review versions to v1
53d6f47 
Signed-off-by: Hector Fernandez <hectorf@vmware.com>
@hectorj2f hectorj2f force-pushed the fix_warnings_kubernetes branch from 8021872 to 53d6f47 Compare August 27, 2021 08:03
@hectorj2f
Copy link
Contributor Author

@cpanato @developer-guy Should we merge this PR ?

@developer-guy developer-guy merged commit fe21c9f into sigstore:main Aug 27, 2021
@developer-guy
Copy link
Member

I think there is a problem with cert-manager helm chart, @hectorj2f would you mind to take a look at the problem ? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@developer-guy developer-guy developer-guy approved these changes

@cpanato cpanato cpanato approved these changes

@dlorenc dlorenc dlorenc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@hectorj2f @dlorenc @developer-guy @cpanato