chore: fix documentation and warning on using untrusted rekor key #2124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Asra Ali <asraa@google.com>
hectorj2f
approved these changes
Aug 3, 2022
Codecov Report
@@ Coverage Diff @@
## main #2124 +/- ##
=======================================
Coverage 26.29% 26.29%
=======================================
Files 130 130
Lines 7597 7597
=======================================
Hits 1998 1998
Misses 5342 5342
Partials 257 257
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Asra Ali asraa@google.com
Summary
Fetching the Rekor key directly from the API is trusted.
Fixes a mistake in documentation from #2040
See #2122
SIGSTORE_REKOR_PUBLIC_KEYCOULD be used, as it specifies the rekor public key out of band.Release Note
Documentation