Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated Azure kms commands. #1972

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Conversation

JBrejnholt
Copy link
Contributor

@JBrejnholt JBrejnholt commented Jun 7, 2022

Use "--kms" instead of "-kms", and used "--key" instead of "-key", as the single dash is deprecated.

Summary

Updated the example script to not use deprecated parameters.

Release Note

* Updated Azure kms document.

@JBrejnholt JBrejnholt changed the title chore: updated Azure kms commands. docs: updated Azure kms commands. Jun 7, 2022
developer-guy
developer-guy previously approved these changes Jun 7, 2022
Copy link
Member

@developer-guy developer-guy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your eagle eyes!

@developer-guy
Copy link
Member

@JBrejnholt, it looks like you didn't sign your commits. Can you please sign them?

@JBrejnholt
Copy link
Contributor Author

@JBrejnholt, it looks like you didn't sign your commits. Can you please sign them?

Added the signature. Thanks.

@dlorenc
Copy link
Member

dlorenc commented Jun 9, 2022

It seems like it didn't quite work :(

@JBrejnholt JBrejnholt force-pushed the patch-1 branch 2 times, most recently from dc82336 to f574065 Compare June 9, 2022 11:56
Use "--kms" instead of "-kms", and used "--key" instead of "-key", as the single dash is deprecated.
Signed-off-by: Jinhong Brejnholt <jinhong.brejnholt@gmail.com>

Author:    Jinhong Brejnholt <jinhong.brejnholt@gmail.com>
Date:      Tue Jun 7 21:30:42 2022 +0200
@JBrejnholt
Copy link
Contributor Author

Can you please check again @dlorenc

@dlorenc
Copy link
Member

dlorenc commented Jun 9, 2022

Can you please check again @dlorenc

All set!

@JBrejnholt
Copy link
Contributor Author

@developer-guy are there anything else missing? :)

@dlorenc
Copy link
Member

dlorenc commented Jun 9, 2022

All set now! Thanks!

@dlorenc dlorenc merged commit 4c41296 into sigstore:main Jun 9, 2022
@github-actions github-actions bot added this to the v1.10.0 milestone Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants