-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate RegExp matching of issuer/subject from strict #1956
Conversation
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Codecov Report
@@ Coverage Diff @@
## main #1956 +/- ##
==========================================
+ Coverage 34.71% 34.90% +0.18%
==========================================
Files 153 153
Lines 10037 10057 +20
==========================================
+ Hits 3484 3510 +26
+ Misses 6166 6162 -4
+ Partials 387 385 -2
Continue to review full report at Codecov.
|
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
… do it. Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Ville Aikas vaikas@chainguard.dev
Summary
Add two new fields issuerRegExp and subjectRegExp so that if the user wants RE matching of issuer/subject, it's crystal clear
that RE is being used. issuer / subject are now strict matches only.
Ticket Link
Fixes #1871
Release Note