-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor fulcio signer to take in KeyOpts. #1788
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlynch
force-pushed
the
fulcio-refactor
branch
2 times, most recently
from
April 22, 2022 16:19
8fc5bcf
to
b37d1f2
Compare
Merged
This commit should not have change in behavior. It changes the fulcio signer to take in the KeyOpts struct instead of passing individual parameters through, as well as moves common code dependent on the values to the same place. The motivation behind this change is to make it easier to add new options without needing to plumb through another param to the already long list. To avoid circular dependencies (sign -> fulcio -> sign), KeyOpts was moved to the options package. Signed-off-by: Billy Lynch <billy@chainguard.dev>
Codecov Report
@@ Coverage Diff @@
## main #1788 +/- ##
==========================================
- Coverage 31.46% 31.45% -0.02%
==========================================
Files 144 144
Lines 8893 8896 +3
==========================================
Hits 2798 2798
- Misses 5758 5761 +3
Partials 337 337
Continue to review full report at Codecov.
|
dlorenc
approved these changes
Apr 22, 2022
wlynch
added a commit
to wlynch/cosign
that referenced
this pull request
Apr 25, 2022
This reverts commit 8368bad.
wlynch
added a commit
to wlynch/cosign
that referenced
this pull request
Apr 25, 2022
This reverts commit 8368bad. Signed-off-by: Billy Lynch <billy@chainguard.dev>
dlorenc
pushed a commit
that referenced
this pull request
Apr 25, 2022
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
This commit should not have change in behavior. It changes the fulcio signer to take in the KeyOpts struct instead of passing individual parameters through, as well as moves common code dependent on the values to the same place. The motivation behind this change is to make it easier to add new options without needing to plumb through another param to the already long list. To avoid circular dependencies (sign -> fulcio -> sign), KeyOpts was moved to the options package. Signed-off-by: Billy Lynch <billy@chainguard.dev>
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
…igstore#1798) This reverts commit 8368bad. Signed-off-by: Billy Lynch <billy@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit should not have change in behavior. It changes the fulcio signer
to take in the KeyOpts struct instead of passing individual parameters through,
as well as moves common code dependent on the values to the same place.
The motivation behind this change is to make it easier to add new options without
needing to plumb through another param to the already long list.
To avoid circular dependencies (sign -> fulcio -> sign), KeyOpts was moved to the
options package.
Ticket Link
Part of #1785 (wanted to make this change first to make adding the option easier)
Release Note