use the upstream kubernetes version lib and ldflags #1413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n3wscott
force-pushed
the
use-k8s-version
branch
from
5102d05 to
1debef8
Compare
Signed-off-by: Scott Nichols <n3wscott@chainguard.dev>
n3wscott
force-pushed
the
use-k8s-version
branch
from
1debef8 to
cd46f5a
Compare
|
cc @cpanato, i like the code deletion but it deletes his really cool ASCII logo! |
:( true but this is not adding another external dependency to the project? besides the fact we loose the starwars logo lol |
|
It supports fonts that you can load if you really want that font back. |
|
that is fine, we don't need to be that picky, maybe I can update that when are bored lol |
cpanato
approved these changes
Feb 10, 2022
hatmarch
pushed a commit
to hatmarch/cosign
that referenced
this pull request
Apr 19, 2022
Signed-off-by: Scott Nichols <n3wscott@chainguard.dev>
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
Signed-off-by: Scott Nichols <n3wscott@chainguard.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See kubernetes-sigs/release-utils#28
This leverages the upstream k8s release-utils version strings and output, so we can drop it locally.
Ticket Link
Relates to kubernetes-sigs/release-utils#23
Release Note