feat: fig autocomplete feature #1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developer-guy
force-pushed
the
feature/1359
branch
from
d99b203 to
5778b6b
Compare
developer-guy
force-pushed
the
feature/1359
branch
from
5778b6b to
ad8fd9c
Compare
|
kindly ping 🙋🏻♂️ |
|
Tried to re-run the CI, something failed in the go-releaser snapshot... |
|
Still failing, maybe try a rebase? /bin/sh: 1: goimports: not found
LDFLAGS="-X github.com/sigstore/cosign/pkg/version.GitVersion=21ca2f4 -X github.com/sigstore/cosign/pkg/version.gitCommit=21ca2f407f5261cee7a10089f9de0f17d5e259ec -X github.com/sigstore/cosign/pkg/version.gitTreeState="clean" -X github.com/sigstore/cosign/pkg/version.buildDate='2022-02-01T07:07:41Z'" goreleaser release --skip-sign --skip-publish --snapshot --rm-dist
• releasing...
• loading config file file=.goreleaser.yml
• loading environment variables
• getting and validating git state
• ignoring errors because this is a snapshot error=git doesn't contain any tags. Either add a tag or use --snapshot
• building... commit=21ca2f407f5261cee7a10089f9de0f17d5e259ec latest tag=v0.0.0
• pipe skipped error=disabled during snapshot mode
• parsing tag
• running before hooks
• running hook=go mod tidy
• running hook=/bin/bash -c 'if [ -n "$(git --no-pager diff --exit-code go.mod go.sum)" ]; then exit 1; fi'
⨯ release failed after 43.37s error=hook failed: /bin/bash -c 'if [ -n "$(git --no-pager diff --exit-code go.mod go.sum)" ]; then exit 1; fi': exit status 1; output:
make: *** [release/release.mk:51: snapshot] Error 1
Error: Process completed with exit code 2. |
developer-guy
force-pushed
the
feature/1359
branch
2 times, most recently
from
277acff to
dfcc618
Compare
|
cc: @cpanato, is that something related to an image |
can you try to run go mod tidy and push the changes? if you ran and there is no change I will take a look |
developer-guy
force-pushed
the
feature/1359
branch
from
dfcc618 to
10af4aa
Compare
you are like a hero 🦸 |
|
but same error :/ |
i will checkout your pr, give me some time |
|
running the job locally it works, trying to check why |
|
in ci it is complaing about |
|
also made a pr to add goimports in the cross builder image: gythialy/golang-cross#87 |
|
and i think i discover why, one sec |
cpanato
requested changes
Feb 9, 2022
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
developer-guy
force-pushed
the
feature/1359
branch
from
10af4aa to
b0e7f57
Compare
|
thank you so much for helping me @cpanato, you're the best |
cpanato
approved these changes
Feb 9, 2022
hatmarch
pushed a commit
to hatmarch/cosign
that referenced
this pull request
Apr 19, 2022
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
mlieberman85
pushed a commit
to mlieberman85/cosign
that referenced
this pull request
May 6, 2022
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com
Summary
will generate autocompletion typescript code of cosign for fig
Ticket Link
Fixes #1359
Release Note