Add support for other public key types for SCT verification, allow override for testing. #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlorenc
reviewed
Dec 22, 2021
| @@ -37,6 +40,10 @@ import ( | |||
| // This is the CT log public key target name | |||
| var ctPublicKeyStr = `ctfe.pub` | |||
|
|
|||
| // Setting this env variable will over ride what is used to validate | |||
| // the SCT coming back from Fulcio. | |||
| const altCTLogPublicKeyLocation = "CT_LOG_PUBLIC_KEY_FILE" | |||
There was a problem hiding this comment.
What do you think about prefixing this with SIGSTORE_? We have some env vars prefixed with COSIGN_ for cosign-specific things, and thenSIGSTORE_ROOT_FILE and SIGSTORE_NO_CACHE for the TUF root itself.
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
dlorenc
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1240
Also when using, say a testing CT log (where I found the above issue), it would be nice to be able to specify a different public key to use for SCT validation, so basically the public key for the CT Log. Other option of course would be to just use the insecure bit, but I reckon this is nicer and allows for more flexibility.
Introduce
CT_LOG_PUBLIC_KEY_FILEenvironmental variable that allows one to override (with nice warnings to boot) where the public key used for validating the SCT.Ticket Link
Fixes
Release Note