-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sign --output-certificate and verify --cert #1095
Conversation
I think it's slightly less useful, but don't see an issue with it. Supporting Go for it! |
I believe its a bit better now... not sure if we want to add the base64 thing to sign as well, as its not an option there today. on that note: I wonder if its worth having it on other commands as well, and why is it the default... seems easy enough to |
Looks like you missed a change in the e2e tests, otherwise this looks pretty close. |
Signed-off-by: Carlos A Becker <caarlos0@gmail.com> Co-authored-by: Matt Moore <mattomata@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
sign-blob
got a--output-certificate
flag, so I thought it would be cool to do the same forsign
.Not sure if this makes sense, and this PR is very WIP just to see if it would work, but, if we decide to get this merged, it seems that we also need a
--cert
on theverify
command.Happy to hear your thoughts on this.
Ticket Link
n/a
Release Note