feat: replace option for same attestation #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjasonh
reviewed
Nov 12, 2021
Signed-off-by: Furkan <furkan.turkal@trendyol.com> Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
|
we also added a target for |
|
Close! |
developer-guy
force-pushed
the
main
branch
2 times, most recently
from
ce0c14d to
74dc60a
Compare
seems okay right now, thanks, I missed it due to build tags 🤦 |
dlorenc
reviewed
Nov 14, 2021
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
dlorenc
approved these changes
Nov 15, 2021
|
@dlorenc should we do the same for signatures? |
mattmoor
reviewed
Nov 19, 2021
| @@ -211,6 +211,13 @@ func (si *signedImage) Attestations() (oci.Signatures, error) { | |||
| return base, nil | |||
| } | |||
| } | |||
| if si.so.ro != nil { | |||
| replace, err := si.so.ro.Replace(base, si.att) | |||
There was a problem hiding this comment.
Looks like these paths aren't covered by current unit tests, can we get some unit tests for these, please? 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Furkan furkan.turkal@trendyol.com
feat: replace option for same attestation
Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com
Summary
replace option for same attestation
Ticket Link
Fixes #923
Release Note
Huge thanks tho @imjasonh !!
cc: @JimBugwadia @dlorenc @cpanato