Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clap derive #3007

Closed
wants to merge 23 commits into from
Closed

Clap derive #3007

wants to merge 23 commits into from

Conversation

realbigsean
Copy link
Member

Issue Addressed

Improves ergonomics of handling CLI flags and takes care of tracking config names in different places. This is somewhat helpful in layering config from different sources as well, which is necessary in the following PRs:

Proposed Changes

Migrate lighthouse to clap derive

@realbigsean realbigsean changed the base branch from stable to unstable February 7, 2022 19:46
@realbigsean realbigsean added the work-in-progress PR is a work-in-progress label Feb 7, 2022
@realbigsean realbigsean mentioned this pull request Feb 7, 2022
Closed
2 tasks
@realbigsean realbigsean added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Feb 8, 2022
@realbigsean realbigsean marked this pull request as ready for review February 8, 2022 15:52
@realbigsean
Copy link
Member Author

The CLI tests are so massive for this! Caught a bunch of issues!

@realbigsean
Copy link
Member Author

Script for checking out the --help diff between two lighthouse binaries: https://gist.github.com/realbigsean/3b1de807c938348fc0ba5d76709d2a37

@realbigsean realbigsean mentioned this pull request Mar 11, 2022
Closed
@paulhauner
Copy link
Member

I'm going to drop the ready-for-review tags due to conflicts. Sorry about letting this one go stale, we can chat about it sometime :)

@paulhauner paulhauner added work-in-progress PR is a work-in-progress and removed ready-for-review The code is ready for review labels Jul 4, 2022
@realbigsean realbigsean added the backlog PR is not currently prioritized label Jul 14, 2022
@realbigsean realbigsean mentioned this pull request Jan 19, 2024
Open
@realbigsean
Copy link
Member Author

realbigsean commented Jan 19, 2024 •
edited by dapplion
Loading

closing, see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backlog PR is not currently prioritized work-in-progress PR is a work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@realbigsean @paulhauner