Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clap, and potentially move to derive #5087

Open
realbigsean opened this issue Jan 19, 2024 · 2 comments
Open

Update clap, and potentially move to derive #5087

realbigsean opened this issue Jan 19, 2024 · 2 comments

Comments

@realbigsean
Copy link
Member

Description

I started on moving to clap derive a while ago, so there is work started that could be picked up, but it's pretty difficult to keep up to date. We'd get a little more compile time safety, but it is a lot of changes, so not totally sure it's worth it. Relevant PRs:

#3007
#2960

This was referenced Jan 19, 2024
@realbigsean realbigsean changed the title Update clap, and potentially moe to derive Update clap, and potentially move to derive Jan 19, 2024
@eserilev
Copy link
Collaborator

eserilev commented Feb 11, 2024

I'd like to try to get this across the finish line. I'm wondering if we could do the clap upgrades in stages, i.e. separate
prs for bootnode, beacon node, vc etc. That way we could avoid one huge PR

EDIT:
After some further investigation it seems like at the very least the BN + bootnode need to be upgraded together. Will see if I can keep the VC to a separate PR.

@realbigsean
Copy link
Member Author

I'd like to try to get this across the finish line. I'm wondering if we could do the clap upgrades in stages, i.e. separate
prs for bootnode, beacon node, vc etc. That way we could avoid one huge PR

I think that's a good idea and from what I remember should be possible, haven't checked out your PR yet but will try to get to it soon (off for the next couple weeks though)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants