Implement Swedish/Cash rounding fixes #63 #66
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I need the following guidance: Have I implemented the rounding correctly? Are there any architecture or other bugs? Is the panic correct? Are comments correct and consistent? How can I (or you) reduce the allocations? There seems to be some tricks in the library to avoid allocations but I'm not familiar with the math/big package. You can also work on the allocs to reduce them. Let me know.
RoundCash aka Cash/Penny/öre rounding rounds decimal to a specific
interval. The amount payable for a cash transaction is rounded to the nearest
multiple of the minimum currency unit available. The following intervals are
available: 5, 10, 15, 25, 50 and 100; any other number throws a panic.
For more details: https://en.wikipedia.org/wiki/Cash_rounding