Fixes Postgres Restore Bug #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thomasmitchell
commented
Jun 9, 2016
thomasmitchell
commented
- Fixes a bug where a Postgres dump file with a line longer than 64K could not be read by the scanner in the Postgres restore plugin.
- The plugin now returns non-0 codes on errors related to reading the file in.
- Fixed an off-by-one error in the debug logs when it says how many lines were in the dump file that was restored.
added 2 commits
June 8, 2016 11:22
Curse you, large Postgres rows
| @@ -271,7 +295,8 @@ func pgConnectionInfo(endpoint ShieldEndpoint) (*PostgresConnectionInfo, error) | |||
| database, err := endpoint.StringValueDefault("pg_database", "") | |||
| DEBUG("PGDATABASE: '%s'", database) | |||
|
|
|||
| bin := "/var/vcap/packages/postgres-9.4/bin" | |||
| //bin := "/var/vcap/packages/postgres-9.4/bin" | |||
| bin := "/var/vcap/packages/postgresql_9.3/bin" | |||
|
Carry on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.