Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Unit like structs for DekuWrite #450

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Support Unit like structs for DekuWrite #450

merged 1 commit into from
Jun 14, 2024

Conversation

wcampbell0x2a
Copy link
Collaborator

  • Fix support for DekuWrite by not adding fields to the struct destruction in deku-write proc-macro
  • Add test

Closes #449

@wcampbell0x2a
Support Unit like structs for DekuWrite
0b57dda 
* Fix support for DekuWrite by not adding fields to the struct destruction
  in deku-write proc-macro
* Add test

Closes #449
@wcampbell0x2a wcampbell0x2a added this to the 0.18.0 milestone Jun 14, 2024
@wcampbell0x2a wcampbell0x2a mentioned this pull request Jun 14, 2024
Closed
@github-actions GitHub Actions
Copy link

Benchmark for 75a4489

Click to view benchmark
Test Base PR %
deku_read_bits 1236.7±15.05ns 1248.1±12.19ns +0.92%
deku_read_byte 3.3±0.04ns 3.3±0.11ns 0.00%
deku_read_enum 2.5±0.07ns 2.5±0.06ns 0.00%
deku_read_vec 33.5±0.30ns 33.3±2.13ns -0.60%
deku_write_bits 170.5±8.78ns 167.3±5.15ns -1.88%
deku_write_byte 22.7±0.44ns 22.8±0.85ns +0.44%
deku_write_enum 21.1±0.20ns 21.1±0.23ns 0.00%
deku_write_vec 336.0±4.04ns 409.8±4.12ns +21.96%

@wcampbell0x2a wcampbell0x2a merged commit a9e2d1d into master Jun 14, 2024
7 of 13 checks passed
@wcampbell0x2a wcampbell0x2a deleted the support-unit-like-structs branch June 14, 2024 12:04
wcampbell0x2a added a commit that referenced this pull request Sep 4, 2024
@wcampbell0x2a
Support Unit like structs for DekuWrite (#450)
b02477c 
* Fix support for DekuWrite by not adding fields to the struct destruction
  in deku-write proc-macro
* Add test

Closes #449
wcampbell0x2a added a commit that referenced this pull request Sep 4, 2024
@wcampbell0x2a
Support Unit like structs for DekuWrite (#450)
75d7f3a 
* Fix support for DekuWrite by not adding fields to the struct destruction
  in deku-write proc-macro
* Add test

Closes #449
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharksforarms sharksforarms sharksforarms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.

Support unit structure struct S; in derive-macro DekuWrite
2 participants
@wcampbell0x2a @sharksforarms