Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Missing Dash Roles to RoleFromString function #1418

Closed
Johmpa opened this issue Aug 13, 2024 · 1 comment · Fixed by #1419
Closed

Add Missing Dash Roles to RoleFromString function #1418

Johmpa opened this issue Aug 13, 2024 · 1 comment · Fixed by #1419
Labels
status: archived Archived and locked; will not be updated

Comments

@Johmpa
Copy link
Contributor

Johmpa commented Aug 13, 2024

System info

Operating System: macOS 14.5
Shaka Packager Version: 3.2.0

Issue and steps to reproduce the problem

As issue #1390 identified, several Dash roles in the specification were missing. These were added and included in the 3.1.0 release.

However, many of the possible roles are not present in the RoleFromString function in period.cc, resulting in a failed packaging since the roles cannot be recognized.

The following roles appear to be missing from the function:

  • karaoke
  • sign
  • metadata
  • enhanced-audio-intelligibility
  • emergency
  • easyreader

Packager Command:

~/Movies/videodev/packager-test/source/shaka-packager/build/packager/packager \
in=avc1080.mp4,stream=audio,output=audio.mp4,playlist_name=audio.m3u8,hls_group_id=audio,hls_name=ENGLISH,dash_roles=karaoke \
 in=avc1080.mp4,stream=video,output=avc.mp4,playlist_name=avc.m3u8,iframe_playlist_name=avc_iframe.m3u8 \
 --hls_master_playlist_output main.m3u8 \
 --mpd_output main.mpd

What is the expected result?
A successful packaging with the role "Karaoke" assigned.

What happens instead?
code: 139, [0813/160352:ERROR:period.cc(208)] Unrecognized role 'karaoke'

cosmin pushed a commit that referenced this issue Aug 29, 2024
As per issue #1418, several Dash roles are missing from the
RoleFromString function, making them unusable in practice. This update
should enable them for use.

---------

Co-authored-by: John Laurin <john.laurin@svt.se>
cosmin pushed a commit that referenced this issue Oct 24, 2024
🤖 I have created a release *beep* *boop*
---


##
[3.2.1](v3.2.0...v3.2.1)
(2024-10-02)


### Bug Fixes

* Add Missing Dash Roles to RoleFromString function
([#1418](#1418))
([#1419](#1419))
([9cb00e9](9cb00e9))
* Break header installation for the shared library
([#1407](#1407))
([b5c2cb8](b5c2cb8)),
closes
[#1406](#1406)
* Embed full python protobuf library
([#1438](#1438))
([f07fd0d](f07fd0d)),
closes
[#1436](#1436)

---
This PR was generated with [Release
Please](/~https://github.com/googleapis/release-please). See
[documentation](/~https://github.com/googleapis/release-please#release-please).
@joeyparrish
Copy link
Member

Closed in #1419

@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Dec 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants