Support refresh of sensu_secrets_vault_provider token_file #1305
+46
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghoneycutt
reviewed
Feb 9, 2021
treydock
force-pushed
the
vault-provider-refresh
branch
from
bd9bf2a to
3f156ab
Compare
treydock
force-pushed
the
vault-provider-refresh
branch
from
3f156ab to
231e356
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
Allow the file for sensu_secrets_vault_provider's token_file parameter to trigger a refresh that will force an update of the token value.
The acceptance tests were changed so that the resources testing token_file had only change taking place being the token_file contents to verify that a refresh event triggers the change without other properties triggering a change. The changes of other properties are tested with other resources in the same tests.