Support Puppet 7 #1288
Merged
Support Puppet 7 #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treydock
force-pushed
the
puppet7
branch
2 times, most recently
from
4e6e834 to
3451a12
Compare
|
Modified pull request to only add Puppet 7 support. |
ghoneycutt
reviewed
Dec 2, 2020
treydock
force-pushed
the
puppet7
branch
2 times, most recently
from
f689bbc to
d7b4d65
Compare
ghoneycutt
reviewed
Dec 14, 2020
| @@ -3,6 +3,15 @@ | |||
| describe 'sensu::backend class', if: ['base','full'].include?(RSpec.configuration.sensu_mode) do | |||
| backend = hosts_as('sensu-backend')[0] | |||
| agent = hosts_as('sensu-agent')[0] | |||
| let(:facter_command) do | |||
There was a problem hiding this comment.
This code is getting duplicated. To DRY things up, could it be moved to the spec_helper?
There was a problem hiding this comment.
Not really. It's best to define variables in rspec using let to ensure proper test isolation and not a great way to do that in central place that I know of. It's also slightly differen logic for Windows tests than other tests so not much to DRY up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
Add support for Puppet 7 (and Facter 4)
I did not use Ruby 2.7.0 for acceptance tests because the RVM version of Ruby used for beaker tests has zero impact on the tests, the version of Ruby and Puppet used for the test is set by
BEAKER_PUPPET_COLLECTIONso you can use whatever version of Ruby is supported by the beaker code and it won't impact the version of Ruby used for actual acceptance tests. The beaker library is not yet validated on Ruby 2.7 so I opted for safest approach while still testing proper version of Puppet and Ruby inside Docker. It's sort of like installing RVM Ruby 2.0.0 on a host and it having no impact on Puppet Ruby because Puppet Ruby is embedded in the puppet-agent package, and the beaker tests are using puppet-agent packages.