Change how it's determined when to run specific acceptance tests #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests are run based on `BEAKER_sensu_mode` environment variable which defaults to `base`
ghoneycutt
reviewed
Apr 15, 2020
| @@ -82,6 +82,15 @@ The class tests are ordered with numeric prefixes to control the order they run. | |||
|
|
|||
| The type of `sensu_check` will have its tests in `sensu_check_spec.rb`. The tests to run are adding resources, updating resources, and deleting resources. Some extra test cases should be added based on any complexities of a given type. | |||
|
|
|||
| The resources `sensu_cluster_role`, `sensu_cluster_role_binding`, `sensu_role`, and `sensu_role_binding` are grouped into `sensu_rbac_resources_spec.rb` with the goal of speeding up testing times. | |||
|
|
|||
| By default only tests for class resources run which is the same as setting the enviornment variable `BEAKER_sensu_mode=base`. The other possible modes are the following: | |||
There was a problem hiding this comment.
I dont see this in .travis.yml, should I?
There was a problem hiding this comment.
The default of base is set in spec/spec_helper_acceptance.rb where the setting is defined. If nothing is defined it defaults to base.
ghoneycutt
reviewed
Apr 15, 2020
| stage: acceptance | ||
| - rvm: 2.5.7 | ||
| services: docker | ||
| env: BEAKER_set="centos-7" BEAKER_PUPPET_COLLECTION=puppet6 BEAKER_sensu_mode=examples |
There was a problem hiding this comment.
Think we're missing puppet5 for examples
There was a problem hiding this comment.
Updated to have puppet5 tested too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description
Tests are run based on
BEAKER_sensu_modeenvironment variable which defaults tobaseThis doesn't change when or how things are tested, just splits tests into smaller groups so things like examples will run separate than custom types. The core centos7 tests will run like all other OSes but also include postgresql tests and bolt which were also only done with centos7 before. It's still only centos7 that is used to test clusters and custom types.