Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve login component error handling. Add busy indicator. #195

Closed
2jour opened this issue Oct 30, 2015 · 3 comments
Closed

Improve login component error handling. Add busy indicator. #195

2jour opened this issue Oct 30, 2015 · 3 comments
Assignees
@rschamp
Milestone
2.2.3 - Hotfix

Comments

@2jour
Copy link

2jour commented Oct 30, 2015

OS: mac osx 10.10.5
Browser: Safari 8, Chrome, FF

When there is a network loss and you try to sign in to the homepage there is no indication that there is a network loss

On the other pages you will see a spinning wheel .

Not sure if related to Jolie's issue but definitely noticed this while testing.
@2jour 2jour added this to the 2.2.3 - HOC milestone Oct 30, 2015
@2jour
Copy link
Author

2jour commented Oct 30, 2015

related to #196? not sure logged both and can mark as dupe if this is the case

@rschamp
Copy link
Contributor

rschamp commented Oct 30, 2015

Seems like it would help identify it at least.

@rschamp rschamp changed the title [LOGIN] No Indication Network Loss On Homepage Improve login component error handling. Add busy indicator. Oct 30, 2015
@2jour
Copy link
Author

2jour commented Oct 30, 2015

Ok definitely better title :)

@2jour 2jour assigned 2jour and rschamp and unassigned 2jour Nov 2, 2015
rschamp added a commit that referenced this issue Nov 11, 2015
@rschamp
Merge pull request #211 from rschamp/bugfix/GH-195
7c0363e 
Fix GH-195: Use a spinner component to convey activity while logging in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rschamp rschamp

Labels
None yet
Projects
None yet
Milestone
2.2.3 - Hotfix
Development

No branches or pull requests
3 participants
@thisandagain @rschamp @2jour