Fix multiple store instances sharing the same state #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The propsChange reducer was mutating state AND returning a new state object. This is unsupported in immer, and the fix is to only either mutate or only return the new state. I went ahead with mutation as it's much easier on the developer.
The initial state object which is passed to createSlice was reused across multiple store instances. Fixed it by having the `initialize` reducer take care of instantiating a new copy to be used as the initial state.
pradeepnschrodinger
requested review from
deshpsuy,
wcjordan,
miskreant and
somavara
deshpsuy
approved these changes
Nov 20, 2021
pradeepnschrodinger
changed the base branch from
v2.0-beta-fix-rowExpansion
to
v2.0-beta
pradeepnschrodinger
added a commit
that referenced
this pull request
Dec 1, 2021
The initial state object which is passed to createSlice was reused across multiple store instances. Fixed it by having the `initialize` reducer take care of instantiating a new copy to be used as the initial state.
|
Merged locally through v2.0.0-beta.5 |
pradeepnschrodinger
deleted the
v2.0-beta-fix-multiple-stores-sharing-state
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The initial state object which is passed to
createSlicewas reused across multiple store instances.This can lead to issues, similar to what we encountered in #369. I think this was re-introduced sometime during the redux-toolkit migration.
Fixed it by having the
initializereducer take care of instantiating a new copy to be used as the initial state.Motivation and Context
#369
How Has This Been Tested?
Tested in LD and using our examples.
Types of changes
Checklist: