Upgrade React to 16 for dev & tests #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcjordan
requested review from
mycrobe,
novakps,
somavara and
pradeepnschrodinger
wcjordan
commented
Jun 27, 2020
| var clock, sandbox, requestAnimationFramePolyfillSpy; | ||
|
|
||
| before(function () { | ||
| clock = sinon.useFakeTimers(); |
There was a problem hiding this comment.
since all tests share a sandbox I moved this down to the test which actually uses it.
There was a problem hiding this comment.
nit: clock is defined below in the actual test, so we don't need the declaration here.
|
Is there an update on this? |
pradeepnschrodinger
approved these changes
Jul 1, 2020
| var clock, sandbox, requestAnimationFramePolyfillSpy; | ||
|
|
||
| before(function () { | ||
| clock = sinon.useFakeTimers(); |
There was a problem hiding this comment.
nit: clock is defined below in the actual test, so we don't need the declaration here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade React to React 16 in our dev & test envs. Also updated Sinon and switched to the default sandbox.
Motivation and Context
Want to start using React 16 more, so figured a start was to up our dev env.
How Has This Been Tested?
Tests & site-dev-server
Screenshots (if appropriate):
Types of changes
Checklist: