feat: add a method to programatically focus and open the dropdown element #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOMADE55
requested review from
ckrook,
mistermalm,
theJohnnyMe,
EmelieLitwin,
nathalielindqvist,
Lunkan89 and
timrombergjakobsson
as code owners
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
mJarsater
reviewed
Nov 27, 2024
theJohnnyMe
approved these changes
Dec 2, 2024
Lunkan89
approved these changes
Dec 3, 2024
|
@NOMADE55 you can rebase develop and then we can merge this one :) |
Lunkan89
force-pushed
the
feat/add-focus-method-to-dropdown
branch
from
50f3430 to
8764eb1
Compare
|
Lunkan89
merged commit bef2cc5
into
scania-digital-design-system:develop
4 checks passed
|
I wasn't free until now. I see it already merged, glad to know! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe pull-request
Adds a method to focus and open dropdown element programmatically.
Issue Linking:
How to test
Provide detailed steps for testing, including any necessary setup.
Whether you're using angular, react or web components
focusElement()method.Checklist before submission
npm run build-allwithout errorsSuggested test steps
Additional context
An important note, method is named
focusElementasfocusis a reserved name.I'm not really keen on this name, falling victim of the second hardest problem in programming, so feel free to suggest/change it to something more Tegel-ly.