Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a guide to test changes locally #866

Conversation

NOMADE55
Copy link
Contributor

@NOMADE55 NOMADE55 commented Nov 26, 2024

Describe pull-request

Adds a short but sweet guide to play locally with changes made to the Tegel Design System. helping future contributors test behaviors thoroughly.

Issue Linking:

  • No issue: No guide on how to test Tegel locally.

Checklist before submission

  • I have added unit tests for my changes (if applicable)
  • All existing tests pass
  • I have updated the documentation (if applicable)
  • Not breaking production behavior
  • Behavior available in storybook with documented descriptions (if applicable)
  • npm run build-all without errors

Additional context

Keeping my word #861

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-866.d3fazya28914g3.amplifyapp.com

Copy link
Collaborator

@Lunkan89 Lunkan89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Geat explanation, well done!

Copy link
Contributor

@theJohnnyMe theJohnnyMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, thanks a lot @NOMADE55 !

@theJohnnyMe theJohnnyMe merged commit 37f38ee into scania-digital-design-system:develop Nov 27, 2024
3 checks passed
@@ -23,6 +23,22 @@
## Style Guides
- **Code Style**: Please read our [Code Style](/~https://github.com/scania-digital-design-system/tegel/blob/main/CODE_STYLE.md) before contributing.

## Testing your changes locally
To properly test your changes' behaviors in a project, reference your local Tegel instance instead of the published version on the registry
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To properly test your changes' behaviors in a project, reference your local Tegel instance instead of the published version on the registry
To properly test your changes in a project, reference your local Tegel instance instead of the published version on the registry

@NOMADE55
Copy link
Contributor Author

Glad to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants