Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(text-field): counter label color in disabled state #845

Merged
merged 2 commits into from
Nov 13, 2024
Merged

fix(text-field): counter label color in disabled state #845

merged 2 commits into from
Nov 13, 2024

Conversation

ckrook
Copy link
Collaborator

@ckrook ckrook commented Nov 12, 2024 •
edited
Loading

Describe pull-request

This PR address the color on the text field counter label when its disabled. Adding a more toned down grey color to it when its disabled.

Issue Linking:

CDEP-2669

How to test

  1. Go to aws storybook link
  2. Navigate to the textfield component
  3. Add an limit to the textfield text and toggle disabled controller to true.
  4. Make sure it works as intended.
  5. Also change to dark mode to make sure it looks good here as well.

Checklist before submission

  • All existing tests pass
  • Not breaking production behavior
  • npm run build-all without errors

Suggested test steps

  • Browser testing (Chrome, Safari, Firefox)
  • Storybook controls
  • Dark/light mode and variants

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link
Contributor

Playwright test results

passed  391 passed
skipped  1 skipped

Details

stats  392 tests across 132 suites
duration  53.4 seconds
commit  f852ca0

Skipped tests

src/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true

@aws-amplify-eu-north-1 AWS Amplify (eu-north-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-845.d3fazya28914g3.amplifyapp.com

@theJohnnyMe theJohnnyMe changed the title Fix: counter label color in disabled state fix(text-field): counter label color in disabled state Nov 13, 2024
theJohnnyMe
theJohnnyMe approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@theJohnnyMe theJohnnyMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Lunkan89
Lunkan89 reviewed Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@Lunkan89 Lunkan89 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ckrook ckrook merged commit 63bd832 into develop Nov 13, 2024
3 checks passed
@ckrook ckrook deleted the fix/color-counter-disabled-state branch November 13, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lunkan89 Lunkan89 Lunkan89 approved these changes

@theJohnnyMe theJohnnyMe theJohnnyMe approved these changes

@mistermalm mistermalm Awaiting requested review from mistermalm mistermalm is a code owner

@EmelieLitwin EmelieLitwin Awaiting requested review from EmelieLitwin EmelieLitwin is a code owner

@nathalielindqvist nathalielindqvist Awaiting requested review from nathalielindqvist nathalielindqvist is a code owner

@timrombergjakobsson timrombergjakobsson Awaiting requested review from timrombergjakobsson timrombergjakobsson is a code owner

Assignees

@ckrook ckrook

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ckrook @theJohnnyMe @Lunkan89