-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tds-slider): removed preventDefault for touchMove #842
fix(tds-slider): removed preventDefault for touchMove #842
Conversation
Quality Gate passedIssues Measures |
Playwright test resultsDetails 391 tests across 132 suites Skipped testssrc/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true |
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise looks good! Will try and test it in emulator as well!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Describe pull-request
Removed preventDefault for touchmove.
Tested on:
Issue was confirmed on Chrome emulated android devices.
Issue Linking:
Choose one of the following options
How to test
Provide detailed steps for testing, including any necessary setup.
Checklist before submission
npm run build-all
without errorsSuggested test steps