Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tds-slider): removed preventDefault for touchMove #842

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

Lunkan89
Copy link
Collaborator

@Lunkan89 Lunkan89 commented Nov 11, 2024

Describe pull-request

Removed preventDefault for touchmove.
Tested on:

  • Chrome device: Galaxy S8+, Surface Pro 7, iPhone SE, iPad Air
  • Physical devices: iPhone 14 Pro Max, iPad Pro

Issue was confirmed on Chrome emulated android devices.

Issue Linking:

Choose one of the following options

How to test

Provide detailed steps for testing, including any necessary setup.

  1. Go to amplify link in chrome.
  2. Open any android device through inspector device emulator, slider should now work.

Checklist before submission

  • I have added unit tests for my changes (if applicable)
  • All existing tests pass
  • I have updated the documentation (if applicable)
  • Not breaking production behavior
  • Behavior available in storybook with documented descriptions (if applicable)
  • npm run build-all without errors

Suggested test steps

  • Browser testing (Chrome, Safari, Firefox)
  • Keyboard operability
  • Interactive elements have labels.
  • Storybook controls
  • Design/controls/props is aligned with other components
  • Dark/light mode and variants
  • Input fields – values should be displayed properly
  • Events

Copy link

@Lunkan89 Lunkan89 changed the title fix: removed preventDefault on toushmove fix: removed preventDefault in tdsSlider touchMove Nov 11, 2024
@Lunkan89 Lunkan89 changed the title fix: removed preventDefault in tdsSlider touchMove fix(tds-slider): removed preventDefault for touchMove Nov 11, 2024
Copy link
Contributor

Playwright test results

passed  390 passed
skipped  1 skipped

Details

stats  391 tests across 132 suites
duration  55.4 seconds
commit  01c9609

Skipped tests

src/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-842.d3fazya28914g3.amplifyapp.com

Copy link
Contributor

@timrombergjakobsson timrombergjakobsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise looks good! Will try and test it in emulator as well!

Copy link
Contributor

@theJohnnyMe theJohnnyMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked by using "Nest Hub Max" in Chrome emulator and it looks ok.

comparison

Probably we would need to add feature that once you tap or click somewhere on the slider rail, that thumb would locate itself there, but that is for another PR.

@Lunkan89
Copy link
Collaborator Author

Checked by using "Nest Hub Max" in Chrome emulator and it looks ok.

comparison

Probably we would need to add feature that once you tap or click somewhere on the slider rail, that thumb would locate itself there, but that is for another PR.

Yes, I`ll create a ticker for it

@Lunkan89 Lunkan89 merged commit 00e686b into develop Nov 12, 2024
3 checks passed
@Lunkan89 Lunkan89 deleted the fix/CDEP-3566-slider-android-interaction-error branch November 12, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants