-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(storybook-table): controls for overflow #811
docs(storybook-table): controls for overflow #811
Conversation
Playwright test resultsDetails 391 tests across 132 suites Failed testssrc/components/popover-menu/test/default/popover-menu.e2e.ts › tds-popover-menu-default › clicking the trigger button should open the popover menu dialog Skipped testssrc/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true |
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aren't these changes in #793 also?
Quality Gate passedIssues Measures |
I am bringing this back as the develop branch does not have correct controls again. |
Describe pull-request
Adding missing config for storybook controls on expandable story
Issue Linking:
How to test
Checklist before submission
npm run build-all
without errorsSuggested test steps