Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(table): add part for the cell in the expanded row of the table. add visible for overflow. #789

Merged
merged 4 commits into from
Oct 16, 2024
Merged

feat(table): add part for the cell in the expanded row of the table. add visible for overflow. #789

merged 4 commits into from
Oct 16, 2024

Conversation

patrikhultgren
Copy link
Collaborator

@patrikhultgren patrikhultgren commented Oct 8, 2024 •
edited
Loading

Describe pull-request

The purpose of this PR is to provide an option to remove the padding in the expanded area. Additionally, I want to have control over the overflow behavior. Otherwise, it might cause elements like dropdowns to be cut off.

The proposed technical solution is to add a "part" that allows styling of the expanded area in an expanded table row. This would enable adjustments like removing padding, allowing the expanded area to utilize its full width.

More information can be found in the Teams channel "Development support - Tegel".

Issue Linking:

Checklist before submission

  • All existing tests pass
  • Not breaking production behavior
  • npm run build-all without errors

Suggested test steps

  • Browser testing (Chrome, Safari, Firefox)

@patrikhultgren patrikhultgren mentioned this pull request Oct 8, 2024
Closed
5 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024 •
edited
Loading

Playwright test results

passed  387 passed

Details

stats  387 tests across 130 suites
duration  51.7 seconds
commit  6f3ba06

@aws-amplify-eu-north-1 AWS Amplify (eu-north-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-789.d3fazya28914g3.amplifyapp.com

@patrikhultgren patrikhultgren changed the title feat(table): add part for the cell in the expanded row of the table feat(table): add part for the cell in the expanded row of the table. add visible attribute for the overflow property. Oct 8, 2024
@timrombergjakobsson timrombergjakobsson added the 🤝 contribution Successful contribution from collaborator label Oct 8, 2024
@Lunkan89
Copy link
Collaborator

Lunkan89 commented Oct 8, 2024

@patrikhultgren looking good! maybe just add visible to storybook controls as well.

@patrikhultgren
Copy link
Collaborator Author

patrikhultgren commented Oct 8, 2024 •
edited
Loading

@patrikhultgren looking good! maybe just add visible to storybook controls as well.

Thanks @Lunkan89 :) Of course, done!

@patrikhultgren patrikhultgren changed the title feat(table): add part for the cell in the expanded row of the table. add visible attribute for the overflow property. feat(table): add part for the cell in the expanded row of the table. add visible for overflow. Oct 8, 2024
@ckrook
Copy link
Collaborator

ckrook commented Oct 9, 2024

@patrikhultgren , regarding your point in the teams thread. Its possible to avoid the overflow scroll in x-axis by setting overflow="hidden".

https://tds-storybook.tegel.scania.com/?path=/story/components-table--expandable-rows&args=overflow:hidden

@patrikhultgren
Copy link
Collaborator Author

patrikhultgren commented Oct 9, 2024 •
edited
Loading

Yes, I’ve noticed that, but the issue is that the parent element still has overflow: auto, which is causing problems. @ckrook

overflow

theJohnnyMe
theJohnnyMe approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@theJohnnyMe theJohnnyMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Charles and I added small changes to meet the contributor needs while leaving default behaviour intact.
Changes look good to me.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@theJohnnyMe theJohnnyMe merged commit 4d34c92 into develop Oct 16, 2024
3 checks passed
@theJohnnyMe theJohnnyMe deleted the feat/table-part branch October 16, 2024 13:56
@timrombergjakobsson timrombergjakobsson mentioned this pull request Oct 21, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lunkan89 Lunkan89 Lunkan89 approved these changes

@theJohnnyMe theJohnnyMe theJohnnyMe approved these changes

@ckrook ckrook Awaiting requested review from ckrook ckrook is a code owner

@nathalielindqvist nathalielindqvist Awaiting requested review from nathalielindqvist nathalielindqvist is a code owner

@timrombergjakobsson timrombergjakobsson Awaiting requested review from timrombergjakobsson timrombergjakobsson is a code owner

@mistermalm mistermalm Awaiting requested review from mistermalm mistermalm is a code owner

Assignees

@patrikhultgren patrikhultgren

Labels
🤝 contribution Successful contribution from collaborator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@patrikhultgren @Lunkan89 @ckrook @theJohnnyMe @timrombergjakobsson