Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table-input-wrappers): dark mode color update #725

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

theJohnnyMe
Copy link
Contributor

Describe pull-request

Colors update for dark mode on table input wrappers after Laurens' review

Issue Linking:

  • No issue: No issue created.

How to test

  1. Laurens to confirm new colors look OK.

Checklist before submission

  • I have added unit tests for my changes (if applicable)
  • All existing tests pass
  • I have updated the documentation (if applicable)

Suggested test steps

  • Browser testing (Chrome, Safari, Firefox)
  • Keyboard operability
  • Interactive elements have labels.
  • Storybook controls
  • Design/controls/props is aligned with other components
  • Dark/light mode and variants
  • Input fields – values should be displayed properly
  • Events

@theJohnnyMe theJohnnyMe self-assigned this Aug 22, 2024
Copy link
Contributor

github-actions bot commented Aug 22, 2024

Playwright test results

passed  361 passed

Details

stats  361 tests across 111 suites
duration  48.7 seconds
commit  cf26b69

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-725.d3fazya28914g3.amplifyapp.com

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
90.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@theJohnnyMe theJohnnyMe merged commit fad5fef into develop Aug 23, 2024
2 of 3 checks passed
@theJohnnyMe theJohnnyMe deleted the fix/table-wrappers-dark-mode branch August 23, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant