Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table-header-cell): added disable padding prop #679

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

Lunkan89
Copy link
Collaborator

@Lunkan89 Lunkan89 commented Jul 9, 2024

Describe pull-request

Simular to table-body-cell we add a prop to table-header-cell that removes all padding. Intended to be used when adding custom components like a input field in a header.

Issue Linking:

Choose one of the following options

How to test

Provide detailed steps for testing, including any necessary setup.

  1. Go to...
  2. Check in...
  3. Run ...

Checklist before submission

  • I have added unit tests for my changes (if applicable)
  • All existing tests pass
  • I have updated the documentation (if applicable)

Suggested test steps

  • Browser testing (Chrome, Safari, Firefox)
  • Keyboard operability
  • Interactive elements have labels.
  • Storybook controls
  • Design/controls/props is aligned with other components
  • Dark/light mode and variants
  • Input fields – values should be displayed properly
  • Events

Screenshots

Include before/after screenshots for UI changes.

Additional context

Add any other context or feedback requests about the pull-request here.

Copy link

sonarqubecloud bot commented Jul 9, 2024

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-679.d3fazya28914g3.amplifyapp.com

Copy link
Contributor

@theJohnnyMe theJohnnyMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! LGTM ;)

@Lunkan89 Lunkan89 merged commit 4c21e00 into develop Jul 10, 2024
2 checks passed
@Lunkan89 Lunkan89 deleted the feat/CDEP-3261-disable-padding-prop branch July 10, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants