feat(modal): Expose a closable property to be able to hide x icon

[mistermalm]

Describe pull-request

Expose a collapsible property to be able to hide x icon

Issue Linking:

• Jira: CDEP-3294

How to test

1. Set closable property to false.
2. See that the close button is no more.

Checklist before submission

• I have added unit tests for my changes (if applicable)
• All existing tests pass
• [] I have updated the documentation (if applicable)

Suggested test steps

• Browser testing (Chrome, Safari, Firefox)
• Keyboard operability
• Interactive elements have labels.
• Storybook controls
• Design/controls/props is aligned with other components
• Dark/light mode and variants
• Input fields – values should be displayed properly
• Events

Additional context

Unit tests will be added if requested.

[aws-amplify-eu-north-1]

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-619.d3fazya28914g3.amplifyapp.com

[timrombergjakobsson]

Nice man! Maybe we should add a test case for covering this also?

[mJarsater]

I think this has been requested before and if I remember correctly this is a design decision. That the modal should always have a close button?

[theJohnnyMe]

I think this has been requested before and if I remember correctly this is a design decision. That the modal should always have a close button?

I had the same memory so I asked yesterday about it but designers approved it. I am not sure if was I confusing it with the banner component thou.

[timrombergjakobsson]

I think this has been requested before and if I remember correctly this is a design decision. That the modal should always have a close button?

I had the same memory so I asked yesterday about it but designers approved it. I am not sure if was I confusing it with the banner component thou.

Yes, I think memory serves you correct. Although as I believe you can hide it in Figma, it made sense to have this flexibility in the component also. But please, @charlottelorensson or Laurens, you could also give your view on it.

[nathalielindqvist]

Works as expected, nicely done! Maybe introduce a test case for it to cover all bases? 😄

[mistermalm]

I agree that it's not best practice UX to disable the close button, sometimes users do not want to make a decision, even if it has a cancel button, they just want to close.

Will add tests as well to ensure quality

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[mistermalm]

I have now pushed tests for close button aswell

[nathalielindqvist]

LGTM, great work! 🚀

[theJohnnyMe]

LGTM