docs(contribution): post feedback update #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theJohnnyMe
requested review from
timrombergjakobsson,
finnlake,
gokberknur,
HasanVatansever,
adarean5,
nathalielindqvist,
mJarsater and
AndreasRasovicScania
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
Thanks @timrombergjakobsson for really good grammar and typo suggestions, you are a star! I have also added link to GitHub discussions too ;) |
theJohnnyMe
force-pushed
the
docs/CDEP-3255-contribution-docs
branch
from
3f70ad2 to
f8138d7
Compare
|
@timrombergjakobsson & @nathalielindqvist - I did an update on the pull request template too. |
nathalielindqvist
approved these changes
Apr 22, 2024
timrombergjakobsson
approved these changes
Apr 24, 2024
Co-authored-by: Tim <tim.romberg@scania.com>
Co-authored-by: Tim <tim.romberg@scania.com>
Co-authored-by: Tim <tim.romberg@scania.com>
Co-authored-by: Tim <tim.romberg@scania.com>
Co-authored-by: Tim <tim.romberg@scania.com>
Co-authored-by: Tim <tim.romberg@scania.com>
Co-authored-by: Tim <tim.romberg@scania.com>
Co-authored-by: Tim <tim.romberg@scania.com>
Co-authored-by: Tim <tim.romberg@scania.com>
Co-authored-by: Tim <tim.romberg@scania.com>
Co-authored-by: Tim <tim.romberg@scania.com>
theJohnnyMe
force-pushed
the
docs/CDEP-3255-contribution-docs
branch
from
84e40d1 to
d0bbb01
Compare
|
timrombergjakobsson
added a commit
that referenced
this pull request
May 16, 2024
* test(table): regenerating new screenshots (#591) * test(dropdown): adding test case for filter reset button (#582) * fix(header-launcher): null check (#517) * fix(header-luncher): null check * fix(header-launcher): simplify existance of launcher-list in DOM --------- Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> * fix: add mdx extensions stories back * text(text-field): password error unit test (#569) * text(text-field): password error unit test * test(text-field): use parallel * test(text-field): read-only and success state (#571) * test(text-field): read-only and success state * chore: missing change * test(text-field): added parralel * test(datetime): unittest for datetime (#577) * test(datetime): test for type datetime-local * test(tds-datetime): added test cases for error and success * test(tds-datetime): updating to correct icon assertion * test(datetime): adding screenshot verification * test(datetime): update to correct format of value * Update packages/core/src/components/datetime/test/default/datetime.e2e.ts Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> * Update packages/core/src/components/datetime/test/error/datetime.e2e.ts Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> * test(datetime): more scenarios covered --------- Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> * test(tooltip): test cases for tooltip added (#583) * test(tooltip): test cases for tooltip added * test(tooltip): updating index.html * test: no need for timeout * test(tooltip): screenshot pixel value fix * fix(popover-core): close instances of component when another opens (#595) * fix(popover-core): close other instances of component when another one is opened * chore: spacing in example * fix(toast): update default header, subheader and link text in Storybook example (#597) * fix(table): disable-padding with compact design (#594) * fix(table): enable compact mode and disabled padding to work simultaneously * fix(table): set top and bottom padding for table header text * fix(table): conditionally set padding rules * fix(header-dropdown): close on slotted items click (#593) * fix(header-dropdown): close on slotted items click * fix(header-dropdown): add listner to parent list instead of every slotted element * fix: onclick on slot level * chore: removing console.log * fix: refactor function * fix: added keyboard event * chore: minor update in popover-core * fix(dropdown): monitor slot changes to assigning defaultValue on dropdown menu update (#599) * fix(dropdown): monitor slot changes to assing defaultValue on dropdown menu update * fix(dropdown): warning message * fix: added warning message for non matching default value * Release of @scania/tegel@1.8.1 (#604) Co-authored-by: nathalielindqvist <nathalielindqvist@users.noreply.github.com> * fix(vars): removing duplicate vars imports (#607) * docs(contribution): post feedback update (#603) * docs(contributions): update according to feedback * docs: added contributing document * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update README.md Co-authored-by: Tim <tim.romberg@scania.com> * docs(contribution): add link to github discussions * docs(pull-request-template): update after feedback * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> --------- Co-authored-by: Tim <tim.romberg@scania.com> * test(accordion): update unit tests (#608) * fix(accordion): update component test path * feat(accordion): add test case for hovering accordion items * feat(accordion): add test for handling click on accordion item * feat(accordion): update tests for disabled state * test(accordion): update test for disabled state * test(accordion): remove excess tests * Update packages/core/src/components/accordion/test/disabled/accordion.e2e.ts Co-authored-by: Tim <tim.romberg@scania.com> * Update packages/core/src/components/accordion/test/disabled/accordion.e2e.ts Co-authored-by: Tim <tim.romberg@scania.com> * Update packages/core/src/components/accordion/test/disabled/accordion.e2e.ts Co-authored-by: Tim <tim.romberg@scania.com> * test(accordion): correct check for not-allowed cursor in disabled test --------- Co-authored-by: Tim <tim.romberg@scania.com> * test(tabs): unit test for tabs added (#610) * test(tabs): unit test for tabs added * Update packages/core/src/components/tabs/test/folder-tabs/folder-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/folder-tabs/folder-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/navigation-tabs/navigation-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/navigation-tabs/navigation-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/navigation-tabs/navigation-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/navigation-tabs/navigation-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * test(tabs): reveiw feedback and refactoring --------- Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * docs(contribution): link correction (#611) * fix(tds-dropdown): improved scrollbar styling (#545) * feat(tds-dropdown): improved scrollbar styling re CDEP-3205 * fix(dropdown scrollbar styled for firefox): styled for Firefox, limited though * Removed TODO comment * fix: review changes * fix: refactoring error, fix * fix: added comments * fix: corrected --tds-dropdown-scrollbar-thumb-color for dark mode * fix: fix thumb colors after new review input * feat(scrollbar): adding general styling to scrollbar * feat(storybook): adding more menu items to rendr scrollbar for demo purpose * Update packages/core/src/components/dropdown/dropdown.scss * fix(scrollbar): adding dark mode var --------- Co-authored-by: Stefan Finnsjö <stefan.finnsjo@scania.com> Co-authored-by: Tim <tim.romberg@scania.com> * build(deps-dev): bump highlight.js in /packages/core (#605) Bumps [highlight.js](/~https://github.com/highlightjs/highlight.js) from 9.13.1 to 11.9.0. - [Release notes](/~https://github.com/highlightjs/highlight.js/releases) - [Changelog](/~https://github.com/highlightjs/highlight.js/blob/main/CHANGES.md) - [Commits](highlightjs/highlight.js@9.13.1...11.9.0) --- updated-dependencies: - dependency-name: highlight.js dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * test(playwright): updating failing screenshot tests (#615) * Release of @scania/tegel@1.8.2 (#616) Co-authored-by: timrombergjakobsson <timrombergjakobsson@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: nathalielindqvist <nathalielindqvist@users.noreply.github.com> Co-authored-by: finnlake <stefan.finnsjo@gmail.com> Co-authored-by: Stefan Finnsjö <stefan.finnsjo@scania.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: timrombergjakobsson <timrombergjakobsson@users.noreply.github.com>
theJohnnyMe
added a commit
that referenced
this pull request
May 22, 2024
* test(table): regenerating new screenshots (#591) * test(dropdown): adding test case for filter reset button (#582) * fix(header-launcher): null check (#517) * fix(header-luncher): null check * fix(header-launcher): simplify existance of launcher-list in DOM --------- Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> * fix: add mdx extensions stories back * text(text-field): password error unit test (#569) * text(text-field): password error unit test * test(text-field): use parallel * test(text-field): read-only and success state (#571) * test(text-field): read-only and success state * chore: missing change * test(text-field): added parralel * test(datetime): unittest for datetime (#577) * test(datetime): test for type datetime-local * test(tds-datetime): added test cases for error and success * test(tds-datetime): updating to correct icon assertion * test(datetime): adding screenshot verification * test(datetime): update to correct format of value * Update packages/core/src/components/datetime/test/default/datetime.e2e.ts Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> * Update packages/core/src/components/datetime/test/error/datetime.e2e.ts Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> * test(datetime): more scenarios covered --------- Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> * test(tooltip): test cases for tooltip added (#583) * test(tooltip): test cases for tooltip added * test(tooltip): updating index.html * test: no need for timeout * test(tooltip): screenshot pixel value fix * fix(popover-core): close instances of component when another opens (#595) * fix(popover-core): close other instances of component when another one is opened * chore: spacing in example * fix(toast): update default header, subheader and link text in Storybook example (#597) * fix(table): disable-padding with compact design (#594) * fix(table): enable compact mode and disabled padding to work simultaneously * fix(table): set top and bottom padding for table header text * fix(table): conditionally set padding rules * fix(header-dropdown): close on slotted items click (#593) * fix(header-dropdown): close on slotted items click * fix(header-dropdown): add listner to parent list instead of every slotted element * fix: onclick on slot level * chore: removing console.log * fix: refactor function * fix: added keyboard event * chore: minor update in popover-core * fix(dropdown): monitor slot changes to assigning defaultValue on dropdown menu update (#599) * fix(dropdown): monitor slot changes to assing defaultValue on dropdown menu update * fix(dropdown): warning message * fix: added warning message for non matching default value * Release of @scania/tegel@1.8.1 (#604) Co-authored-by: nathalielindqvist <nathalielindqvist@users.noreply.github.com> * fix(vars): removing duplicate vars imports (#607) * docs(contribution): post feedback update (#603) * docs(contributions): update according to feedback * docs: added contributing document * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update README.md Co-authored-by: Tim <tim.romberg@scania.com> * docs(contribution): add link to github discussions * docs(pull-request-template): update after feedback * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> --------- Co-authored-by: Tim <tim.romberg@scania.com> * test(accordion): update unit tests (#608) * fix(accordion): update component test path * feat(accordion): add test case for hovering accordion items * feat(accordion): add test for handling click on accordion item * feat(accordion): update tests for disabled state * test(accordion): update test for disabled state * test(accordion): remove excess tests * Update packages/core/src/components/accordion/test/disabled/accordion.e2e.ts Co-authored-by: Tim <tim.romberg@scania.com> * Update packages/core/src/components/accordion/test/disabled/accordion.e2e.ts Co-authored-by: Tim <tim.romberg@scania.com> * Update packages/core/src/components/accordion/test/disabled/accordion.e2e.ts Co-authored-by: Tim <tim.romberg@scania.com> * test(accordion): correct check for not-allowed cursor in disabled test --------- Co-authored-by: Tim <tim.romberg@scania.com> * test(tabs): unit test for tabs added (#610) * test(tabs): unit test for tabs added * Update packages/core/src/components/tabs/test/folder-tabs/folder-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/folder-tabs/folder-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/navigation-tabs/navigation-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/navigation-tabs/navigation-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/navigation-tabs/navigation-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/navigation-tabs/navigation-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * test(tabs): reveiw feedback and refactoring --------- Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * docs(contribution): link correction (#611) * fix(tds-dropdown): improved scrollbar styling (#545) * feat(tds-dropdown): improved scrollbar styling re CDEP-3205 * fix(dropdown scrollbar styled for firefox): styled for Firefox, limited though * Removed TODO comment * fix: review changes * fix: refactoring error, fix * fix: added comments * fix: corrected --tds-dropdown-scrollbar-thumb-color for dark mode * fix: fix thumb colors after new review input * feat(scrollbar): adding general styling to scrollbar * feat(storybook): adding more menu items to rendr scrollbar for demo purpose * Update packages/core/src/components/dropdown/dropdown.scss * fix(scrollbar): adding dark mode var --------- Co-authored-by: Stefan Finnsjö <stefan.finnsjo@scania.com> Co-authored-by: Tim <tim.romberg@scania.com> * build(deps-dev): bump highlight.js in /packages/core (#605) Bumps [highlight.js](/~https://github.com/highlightjs/highlight.js) from 9.13.1 to 11.9.0. - [Release notes](/~https://github.com/highlightjs/highlight.js/releases) - [Changelog](/~https://github.com/highlightjs/highlight.js/blob/main/CHANGES.md) - [Commits](highlightjs/highlight.js@9.13.1...11.9.0) --- updated-dependencies: - dependency-name: highlight.js dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * test(playwright): updating failing screenshot tests (#615) * Release of @scania/tegel@1.8.2 (#616) Co-authored-by: timrombergjakobsson <timrombergjakobsson@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: nathalielindqvist <nathalielindqvist@users.noreply.github.com> Co-authored-by: finnlake <stefan.finnsjo@gmail.com> Co-authored-by: Stefan Finnsjö <stefan.finnsjo@scania.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: timrombergjakobsson <timrombergjakobsson@users.noreply.github.com>
theJohnnyMe
added a commit
that referenced
this pull request
May 27, 2024
* test(table): regenerating new screenshots (#591) * test(dropdown): adding test case for filter reset button (#582) * fix(header-launcher): null check (#517) * fix(header-luncher): null check * fix(header-launcher): simplify existance of launcher-list in DOM --------- Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> * fix: add mdx extensions stories back * text(text-field): password error unit test (#569) * text(text-field): password error unit test * test(text-field): use parallel * test(text-field): read-only and success state (#571) * test(text-field): read-only and success state * chore: missing change * test(text-field): added parralel * test(datetime): unittest for datetime (#577) * test(datetime): test for type datetime-local * test(tds-datetime): added test cases for error and success * test(tds-datetime): updating to correct icon assertion * test(datetime): adding screenshot verification * test(datetime): update to correct format of value * Update packages/core/src/components/datetime/test/default/datetime.e2e.ts Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> * Update packages/core/src/components/datetime/test/error/datetime.e2e.ts Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> * test(datetime): more scenarios covered --------- Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> * test(tooltip): test cases for tooltip added (#583) * test(tooltip): test cases for tooltip added * test(tooltip): updating index.html * test: no need for timeout * test(tooltip): screenshot pixel value fix * fix(popover-core): close instances of component when another opens (#595) * fix(popover-core): close other instances of component when another one is opened * chore: spacing in example * fix(toast): update default header, subheader and link text in Storybook example (#597) * fix(table): disable-padding with compact design (#594) * fix(table): enable compact mode and disabled padding to work simultaneously * fix(table): set top and bottom padding for table header text * fix(table): conditionally set padding rules * fix(header-dropdown): close on slotted items click (#593) * fix(header-dropdown): close on slotted items click * fix(header-dropdown): add listner to parent list instead of every slotted element * fix: onclick on slot level * chore: removing console.log * fix: refactor function * fix: added keyboard event * chore: minor update in popover-core * fix(dropdown): monitor slot changes to assigning defaultValue on dropdown menu update (#599) * fix(dropdown): monitor slot changes to assing defaultValue on dropdown menu update * fix(dropdown): warning message * fix: added warning message for non matching default value * Release of @scania/tegel@1.8.1 (#604) Co-authored-by: nathalielindqvist <nathalielindqvist@users.noreply.github.com> * fix(vars): removing duplicate vars imports (#607) * docs(contribution): post feedback update (#603) * docs(contributions): update according to feedback * docs: added contributing document * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update README.md Co-authored-by: Tim <tim.romberg@scania.com> * docs(contribution): add link to github discussions * docs(pull-request-template): update after feedback * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> --------- Co-authored-by: Tim <tim.romberg@scania.com> * test(accordion): update unit tests (#608) * fix(accordion): update component test path * feat(accordion): add test case for hovering accordion items * feat(accordion): add test for handling click on accordion item * feat(accordion): update tests for disabled state * test(accordion): update test for disabled state * test(accordion): remove excess tests * Update packages/core/src/components/accordion/test/disabled/accordion.e2e.ts Co-authored-by: Tim <tim.romberg@scania.com> * Update packages/core/src/components/accordion/test/disabled/accordion.e2e.ts Co-authored-by: Tim <tim.romberg@scania.com> * Update packages/core/src/components/accordion/test/disabled/accordion.e2e.ts Co-authored-by: Tim <tim.romberg@scania.com> * test(accordion): correct check for not-allowed cursor in disabled test --------- Co-authored-by: Tim <tim.romberg@scania.com> * test(tabs): unit test for tabs added (#610) * test(tabs): unit test for tabs added * Update packages/core/src/components/tabs/test/folder-tabs/folder-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/folder-tabs/folder-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/navigation-tabs/navigation-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/navigation-tabs/navigation-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/navigation-tabs/navigation-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/navigation-tabs/navigation-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * test(tabs): reveiw feedback and refactoring --------- Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * docs(contribution): link correction (#611) * fix(tds-dropdown): improved scrollbar styling (#545) * feat(tds-dropdown): improved scrollbar styling re CDEP-3205 * fix(dropdown scrollbar styled for firefox): styled for Firefox, limited though * Removed TODO comment * fix: review changes * fix: refactoring error, fix * fix: added comments * fix: corrected --tds-dropdown-scrollbar-thumb-color for dark mode * fix: fix thumb colors after new review input * feat(scrollbar): adding general styling to scrollbar * feat(storybook): adding more menu items to rendr scrollbar for demo purpose * Update packages/core/src/components/dropdown/dropdown.scss * fix(scrollbar): adding dark mode var --------- Co-authored-by: Stefan Finnsjö <stefan.finnsjo@scania.com> Co-authored-by: Tim <tim.romberg@scania.com> * build(deps-dev): bump highlight.js in /packages/core (#605) Bumps [highlight.js](/~https://github.com/highlightjs/highlight.js) from 9.13.1 to 11.9.0. - [Release notes](/~https://github.com/highlightjs/highlight.js/releases) - [Changelog](/~https://github.com/highlightjs/highlight.js/blob/main/CHANGES.md) - [Commits](highlightjs/highlight.js@9.13.1...11.9.0) --- updated-dependencies: - dependency-name: highlight.js dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * test(playwright): updating failing screenshot tests (#615) * Release of @scania/tegel@1.8.2 (#616) Co-authored-by: timrombergjakobsson <timrombergjakobsson@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: nathalielindqvist <nathalielindqvist@users.noreply.github.com> Co-authored-by: finnlake <stefan.finnsjo@gmail.com> Co-authored-by: Stefan Finnsjö <stefan.finnsjo@scania.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: timrombergjakobsson <timrombergjakobsson@users.noreply.github.com>
theJohnnyMe
added a commit
that referenced
this pull request
May 28, 2024
* Release @scania/tegel@1.8.2 (#617) * test(table): regenerating new screenshots (#591) * test(dropdown): adding test case for filter reset button (#582) * fix(header-launcher): null check (#517) * fix(header-luncher): null check * fix(header-launcher): simplify existance of launcher-list in DOM --------- Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> * fix: add mdx extensions stories back * text(text-field): password error unit test (#569) * text(text-field): password error unit test * test(text-field): use parallel * test(text-field): read-only and success state (#571) * test(text-field): read-only and success state * chore: missing change * test(text-field): added parralel * test(datetime): unittest for datetime (#577) * test(datetime): test for type datetime-local * test(tds-datetime): added test cases for error and success * test(tds-datetime): updating to correct icon assertion * test(datetime): adding screenshot verification * test(datetime): update to correct format of value * Update packages/core/src/components/datetime/test/default/datetime.e2e.ts Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> * Update packages/core/src/components/datetime/test/error/datetime.e2e.ts Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> * test(datetime): more scenarios covered --------- Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> * test(tooltip): test cases for tooltip added (#583) * test(tooltip): test cases for tooltip added * test(tooltip): updating index.html * test: no need for timeout * test(tooltip): screenshot pixel value fix * fix(popover-core): close instances of component when another opens (#595) * fix(popover-core): close other instances of component when another one is opened * chore: spacing in example * fix(toast): update default header, subheader and link text in Storybook example (#597) * fix(table): disable-padding with compact design (#594) * fix(table): enable compact mode and disabled padding to work simultaneously * fix(table): set top and bottom padding for table header text * fix(table): conditionally set padding rules * fix(header-dropdown): close on slotted items click (#593) * fix(header-dropdown): close on slotted items click * fix(header-dropdown): add listner to parent list instead of every slotted element * fix: onclick on slot level * chore: removing console.log * fix: refactor function * fix: added keyboard event * chore: minor update in popover-core * fix(dropdown): monitor slot changes to assigning defaultValue on dropdown menu update (#599) * fix(dropdown): monitor slot changes to assing defaultValue on dropdown menu update * fix(dropdown): warning message * fix: added warning message for non matching default value * Release of @scania/tegel@1.8.1 (#604) Co-authored-by: nathalielindqvist <nathalielindqvist@users.noreply.github.com> * fix(vars): removing duplicate vars imports (#607) * docs(contribution): post feedback update (#603) * docs(contributions): update according to feedback * docs: added contributing document * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update README.md Co-authored-by: Tim <tim.romberg@scania.com> * docs(contribution): add link to github discussions * docs(pull-request-template): update after feedback * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> --------- Co-authored-by: Tim <tim.romberg@scania.com> * test(accordion): update unit tests (#608) * fix(accordion): update component test path * feat(accordion): add test case for hovering accordion items * feat(accordion): add test for handling click on accordion item * feat(accordion): update tests for disabled state * test(accordion): update test for disabled state * test(accordion): remove excess tests * Update packages/core/src/components/accordion/test/disabled/accordion.e2e.ts Co-authored-by: Tim <tim.romberg@scania.com> * Update packages/core/src/components/accordion/test/disabled/accordion.e2e.ts Co-authored-by: Tim <tim.romberg@scania.com> * Update packages/core/src/components/accordion/test/disabled/accordion.e2e.ts Co-authored-by: Tim <tim.romberg@scania.com> * test(accordion): correct check for not-allowed cursor in disabled test --------- Co-authored-by: Tim <tim.romberg@scania.com> * test(tabs): unit test for tabs added (#610) * test(tabs): unit test for tabs added * Update packages/core/src/components/tabs/test/folder-tabs/folder-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/folder-tabs/folder-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/navigation-tabs/navigation-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/navigation-tabs/navigation-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/navigation-tabs/navigation-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/navigation-tabs/navigation-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * test(tabs): reveiw feedback and refactoring --------- Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * docs(contribution): link correction (#611) * fix(tds-dropdown): improved scrollbar styling (#545) * feat(tds-dropdown): improved scrollbar styling re CDEP-3205 * fix(dropdown scrollbar styled for firefox): styled for Firefox, limited though * Removed TODO comment * fix: review changes * fix: refactoring error, fix * fix: added comments * fix: corrected --tds-dropdown-scrollbar-thumb-color for dark mode * fix: fix thumb colors after new review input * feat(scrollbar): adding general styling to scrollbar * feat(storybook): adding more menu items to rendr scrollbar for demo purpose * Update packages/core/src/components/dropdown/dropdown.scss * fix(scrollbar): adding dark mode var --------- Co-authored-by: Stefan Finnsjö <stefan.finnsjo@scania.com> Co-authored-by: Tim <tim.romberg@scania.com> * build(deps-dev): bump highlight.js in /packages/core (#605) Bumps [highlight.js](/~https://github.com/highlightjs/highlight.js) from 9.13.1 to 11.9.0. - [Release notes](/~https://github.com/highlightjs/highlight.js/releases) - [Changelog](/~https://github.com/highlightjs/highlight.js/blob/main/CHANGES.md) - [Commits](highlightjs/highlight.js@9.13.1...11.9.0) --- updated-dependencies: - dependency-name: highlight.js dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * test(playwright): updating failing screenshot tests (#615) * Release of @scania/tegel@1.8.2 (#616) Co-authored-by: timrombergjakobsson <timrombergjakobsson@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: nathalielindqvist <nathalielindqvist@users.noreply.github.com> Co-authored-by: finnlake <stefan.finnsjo@gmail.com> Co-authored-by: Stefan Finnsjö <stefan.finnsjo@scania.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: timrombergjakobsson <timrombergjakobsson@users.noreply.github.com> * feat(angular-17): new package * docs: update of readme * fix: lock file update after name change * fix: added script to build angular 17 wrappers * docs. switching readmes angular-17 and components * docs: update badge link * fix: made package public for publishing * chore: reverting merge conflict changes * Update packages/angular-17/projects/components/README.md Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * docs: readme update --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Tim <tim.romberg@scania.com> Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: nathalielindqvist <nathalielindqvist@users.noreply.github.com> Co-authored-by: finnlake <stefan.finnsjo@gmail.com> Co-authored-by: Stefan Finnsjö <stefan.finnsjo@scania.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: timrombergjakobsson <timrombergjakobsson@users.noreply.github.com>
timrombergjakobsson
added a commit
that referenced
this pull request
May 29, 2024
…m border (#626) * Release @scania/tegel@1.8.2 (#617) * test(table): regenerating new screenshots (#591) * test(dropdown): adding test case for filter reset button (#582) * fix(header-launcher): null check (#517) * fix(header-luncher): null check * fix(header-launcher): simplify existance of launcher-list in DOM --------- Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> * fix: add mdx extensions stories back * text(text-field): password error unit test (#569) * text(text-field): password error unit test * test(text-field): use parallel * test(text-field): read-only and success state (#571) * test(text-field): read-only and success state * chore: missing change * test(text-field): added parralel * test(datetime): unittest for datetime (#577) * test(datetime): test for type datetime-local * test(tds-datetime): added test cases for error and success * test(tds-datetime): updating to correct icon assertion * test(datetime): adding screenshot verification * test(datetime): update to correct format of value * Update packages/core/src/components/datetime/test/default/datetime.e2e.ts Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> * Update packages/core/src/components/datetime/test/error/datetime.e2e.ts Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> * test(datetime): more scenarios covered --------- Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> * test(tooltip): test cases for tooltip added (#583) * test(tooltip): test cases for tooltip added * test(tooltip): updating index.html * test: no need for timeout * test(tooltip): screenshot pixel value fix * fix(popover-core): close instances of component when another opens (#595) * fix(popover-core): close other instances of component when another one is opened * chore: spacing in example * fix(toast): update default header, subheader and link text in Storybook example (#597) * fix(table): disable-padding with compact design (#594) * fix(table): enable compact mode and disabled padding to work simultaneously * fix(table): set top and bottom padding for table header text * fix(table): conditionally set padding rules * fix(header-dropdown): close on slotted items click (#593) * fix(header-dropdown): close on slotted items click * fix(header-dropdown): add listner to parent list instead of every slotted element * fix: onclick on slot level * chore: removing console.log * fix: refactor function * fix: added keyboard event * chore: minor update in popover-core * fix(dropdown): monitor slot changes to assigning defaultValue on dropdown menu update (#599) * fix(dropdown): monitor slot changes to assing defaultValue on dropdown menu update * fix(dropdown): warning message * fix: added warning message for non matching default value * Release of @scania/tegel@1.8.1 (#604) Co-authored-by: nathalielindqvist <nathalielindqvist@users.noreply.github.com> * fix(vars): removing duplicate vars imports (#607) * docs(contribution): post feedback update (#603) * docs(contributions): update according to feedback * docs: added contributing document * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update README.md Co-authored-by: Tim <tim.romberg@scania.com> * docs(contribution): add link to github discussions * docs(pull-request-template): update after feedback * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> * Update CONTRIBUTING.md Co-authored-by: Tim <tim.romberg@scania.com> --------- Co-authored-by: Tim <tim.romberg@scania.com> * test(accordion): update unit tests (#608) * fix(accordion): update component test path * feat(accordion): add test case for hovering accordion items * feat(accordion): add test for handling click on accordion item * feat(accordion): update tests for disabled state * test(accordion): update test for disabled state * test(accordion): remove excess tests * Update packages/core/src/components/accordion/test/disabled/accordion.e2e.ts Co-authored-by: Tim <tim.romberg@scania.com> * Update packages/core/src/components/accordion/test/disabled/accordion.e2e.ts Co-authored-by: Tim <tim.romberg@scania.com> * Update packages/core/src/components/accordion/test/disabled/accordion.e2e.ts Co-authored-by: Tim <tim.romberg@scania.com> * test(accordion): correct check for not-allowed cursor in disabled test --------- Co-authored-by: Tim <tim.romberg@scania.com> * test(tabs): unit test for tabs added (#610) * test(tabs): unit test for tabs added * Update packages/core/src/components/tabs/test/folder-tabs/folder-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/folder-tabs/folder-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/inline-tabs/inline-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/navigation-tabs/navigation-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/navigation-tabs/navigation-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/navigation-tabs/navigation-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * Update packages/core/src/components/tabs/test/navigation-tabs/navigation-tabs.e2e.ts Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * test(tabs): reveiw feedback and refactoring --------- Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> * docs(contribution): link correction (#611) * fix(tds-dropdown): improved scrollbar styling (#545) * feat(tds-dropdown): improved scrollbar styling re CDEP-3205 * fix(dropdown scrollbar styled for firefox): styled for Firefox, limited though * Removed TODO comment * fix: review changes * fix: refactoring error, fix * fix: added comments * fix: corrected --tds-dropdown-scrollbar-thumb-color for dark mode * fix: fix thumb colors after new review input * feat(scrollbar): adding general styling to scrollbar * feat(storybook): adding more menu items to rendr scrollbar for demo purpose * Update packages/core/src/components/dropdown/dropdown.scss * fix(scrollbar): adding dark mode var --------- Co-authored-by: Stefan Finnsjö <stefan.finnsjo@scania.com> Co-authored-by: Tim <tim.romberg@scania.com> * build(deps-dev): bump highlight.js in /packages/core (#605) Bumps [highlight.js](/~https://github.com/highlightjs/highlight.js) from 9.13.1 to 11.9.0. - [Release notes](/~https://github.com/highlightjs/highlight.js/releases) - [Changelog](/~https://github.com/highlightjs/highlight.js/blob/main/CHANGES.md) - [Commits](highlightjs/highlight.js@9.13.1...11.9.0) --- updated-dependencies: - dependency-name: highlight.js dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * test(playwright): updating failing screenshot tests (#615) * Release of @scania/tegel@1.8.2 (#616) Co-authored-by: timrombergjakobsson <timrombergjakobsson@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: nathalielindqvist <nathalielindqvist@users.noreply.github.com> Co-authored-by: finnlake <stefan.finnsjo@gmail.com> Co-authored-by: Stefan Finnsjö <stefan.finnsjo@scania.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: timrombergjakobsson <timrombergjakobsson@users.noreply.github.com> * fix(accordion): add prop for removing the last accordion item bottom border * fix(accordion): remove comma like it where before * feat(accordion): try remove comma again * feat(accordion): remove unwanted changes from table header cell * fix(accordion): refactor css classes * feat(accordion): shorter css class name * feat(accordion): add e2e test and rename to hide * feat(accordion): add e2e snapshot * feat(accordion): modify e2e snapshot * feat(accordion): change test tiitle --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Tim <tim.romberg@scania.com> Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: nathalielindqvist <nathalielindqvist@users.noreply.github.com> Co-authored-by: finnlake <stefan.finnsjo@gmail.com> Co-authored-by: Stefan Finnsjö <stefan.finnsjo@scania.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: timrombergjakobsson <timrombergjakobsson@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe pull-request
Solving issue*
Fixes: CDEP-3255
How to test