fix(text-field): read-only hides suffix icon #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theJohnnyMe
added
🍾 improvement
🪆 refactor
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
theJohnnyMe
requested review from
mJarsater,
timrombergjakobsson and
nathalielindqvist
mJarsater
reviewed
Mar 19, 2024
theJohnnyMe
force-pushed
the
fix/CDEP-3182-text-fiel-readonly-icon
branch
from
cbd35ab to
dd22353
Compare
mJarsater
approved these changes
Mar 19, 2024
|
|
Seems like it is in prod too @nathalielindqvist. I will check it and if it is simple (it seems), I will fix it in this PR ;) Nice finding really ;) |
|
@nathalielindqvist - Change pushed! ;) |
|
nathalielindqvist
approved these changes
Mar 19, 2024
timrombergjakobsson
added a commit
that referenced
this pull request
Mar 21, 2024
* Release of @scania/tegel@1.6.1 (#525) Co-authored-by: theJohnnyMe <theJohnnyMe@users.noreply.github.com> * feat(date-picker): inital date-picker development (#375) * feat(date picker): inital date picker development * feat(date picker): added custom weekday label support * fix(date picker): added key for itirator * fix(date picker): enable custom date selection * feat(date picker): label, labelPosition and state props added * feat(date picker): added basic language func * feat(date picker): updated calender view if previous or next month date was chosen * feat(range): added a range variant * fix(date-range-picker): removed variant prop * fix(date picker): fixes * fix(date picker): corrected picking date in upcoming/previous months * feat(date): corrected look of "today" date * fix(fixes): fixes * fix(date range picker): cleanup * refactor(date picker): refactored and commented code * refactor(date picker): refactored and slimmed down amount of css variables * refactor(date range picker): removed vars file specific to range * refactor(date range picker): commented and refactored code * docs(date picker): added max control to storybook * fix(date range picker): minor cleanup * fix(date picker): added start and end helper/labels * fix(date picker): aligned value with native date picker attribute * fix(date picker): cleanup * fix(date picker): cleanup * fix(date picker): updated month format * fix(date picker): introduces weekStartsOn property with examples * docs(date picker): updated readme * docs(date picker): updated readmes * feat(date range picker): added weekStartsOn property * fix(date picker): minor accessability improvement * fix(date range picker): minor accessability improvements * feat(date picker): corrected the placeholder * fix(date picker): utilize date-time attribute * fix(date range picker): utilize the date-time attribute * Removed variant from date-range-picker story args * build: dev/production separation * build: different storybook and build rules for dev and prod environment * chore: clean up --------- Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> * build(deps-dev): bump ip from 2.0.0 to 2.0.1 in /packages/core (#519) Bumps [ip](/~https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump ip from 2.0.0 to 2.0.1 in /packages/angular (#520) Bumps [ip](/~https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps-dev): bump ip from 1.1.8 to 1.1.9 in /icons (#523) Bumps [ip](/~https://github.com/indutny/node-ip) from 1.1.8 to 1.1.9. - [Commits](indutny/node-ip@v1.1.8...v1.1.9) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * test(checkbox): added unit tests (#512) * test(checkbox): adding test for disabled and indeterminate state * test(checkbox): update scenario * test: snapshot update * test(checkbox): updating test as per review * test(checkbox): target label correctly * style: adding label test --------- Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> * fix(slider): emit tdsChange on mouse-up and touch-end events (#513) * fix(slider): emit tdsChange on mouse-up and touch-ed events * fix(slider): tdsInput event * fix: drop conts in story * fix(slider): avoid double events + ux improvement * refactor: do not repeat yourself * chore: docs update * docs: update to conventions and contribution (#532) * docs: update to conventions and contribution * Update .github/CODE_STYLE.md Co-authored-by: mJarsater <62651103+mJarsater@users.noreply.github.com> * docs: review feedback --------- Co-authored-by: mJarsater <62651103+mJarsater@users.noreply.github.com> * ci: main as reference (#540) * ci: use release branch (#542) * ci: use release branch * ci: fix * test(chip): added unit tests (#537) * feat(chip): initial default unit test * test(chip): update default test * test(chip): update default test * test(chip): add initial test for chip type radio * test(chip): add type radio button test * test(chip): add tests for type radio * test(chip): add tests for type radio * test(chip): add tests for type checkbox * test(chip): add tests for chip with icon * test(chip): update test for chip with icon * fix(toast): remove content ellipsis and add margin to close button (#538) * feat(toast): make close button optional (#550) * feat(toast): make close button optional * fix(toast): update word break rule * ci: release all script improvement (#544) * feat(modal): re-initilize selecor and clean-up method (#552) * build(stencil): v4.12.6 (#553) * build(deps-dev): bump follow-redirects in /packages/angular (#551) Bumps [follow-redirects](/~https://github.com/follow-redirects/follow-redirects) from 1.15.4 to 1.15.6. - [Release notes](/~https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.4...v1.15.6) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(text-field): read-only hides suffix icon (#554) * fix(text-field): read-only hides suffix icon * test: adding a test case for read-only & suffix * docs(text-filed): read-only & suffix description * fix(text-field): read-only icon position * fix(table-body-cell): Behavior and additional `text-align` values in `tds-header-cell` and `tds-body-cell` (#555) * feat: improved and added additional `center` text alignment feature to `tds-header-cell` component * feat: improved and added additional `center` text alignment feature to `tds-body-cell` component * feat: improved `text-align` behavior * test: added controls in StoryBook * test: added controls in StoryBook * test: added controls in StoryBook * fix: added default values for `tds-body-cell` * Update packages/core/src/components/table/table-header-cell/table-header-cell.tsx Co-authored-by: theJohnnyMe <johnny.bradata.kurva@gmail.com> * Update packages/core/src/components/table/table-component-basic.stories.tsx Co-authored-by: theJohnnyMe <johnny.bradata.kurva@gmail.com> * fix: minor alingment & standardization * fix: text alignment in sortable header cell --------- Co-authored-by: theJohnnyMe <johnny.bradata.kurva@gmail.com> Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> * test(text-field): default test case (#558) * test(table-expandable): increae tolerance in screenshots * test(text-field): default test case * test(table-filtering): increase pixel tolerance * Release of @scania/tegel@1.7.0 (#560) Co-authored-by: timrombergjakobsson <timrombergjakobsson@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: theJohnnyMe <theJohnnyMe@users.noreply.github.com> Co-authored-by: mJarsater <62651103+mJarsater@users.noreply.github.com> Co-authored-by: theJohnnyMe <nikola.johnny.mirkovic@scania.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Nathalie Lindqvist <nathalie.lindqvist@scania.com> Co-authored-by: Andreas Rasovic <163417029+AndreasRasovicScania@users.noreply.github.com> Co-authored-by: theJohnnyMe <johnny.bradata.kurva@gmail.com> Co-authored-by: timrombergjakobsson <timrombergjakobsson@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe pull-request
When using the suffix icon and read-only, the read-only icon takes priority, and the suffix icon remains hidden.
Solving issue
Fixes: CDEP-3182
#522
How to test
Checklist before submission
Suggested test steps