-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dropdown): reset natively #1006
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Playwright test resultsDetails
Failed testssrc/components/popover-canvas/test/default/popover-canvas.e2e.ts › tds-popover-canvas-default-lightmode › renders default popover-canvas correctly Skipped testssrc/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true |
This is a nice idea to handle native reset ;) Please consider using disconnectCallback to clean up eventListeners. You will find examples in a couple of components in the system. Check out what AI thinks about it. @mistermalm & @max-umain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9fbd08a
to
fb2199e
Compare
fb2199e
to
1b85b88
Compare
|
Describe pull-request
This change will listen to the closest form to natively reset the dropdown values.
Issue Linking:
How to test
Provide detailed steps for testing, including any necessary setup.