-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deployment target to match React Native (8.0) #91
Conversation
Hi @ndbroadbent! Have you checked the implications of this change? Are the ads SDK supported for iOS 8.0? |
Hi, I did test this on the iOS Simulator running iOS 8.4, and everything seemed to work fine. I think the SDK supports iOS 7 and higher: https://firebase.google.com/docs/admob/ios/download |
Also works for us with the target set to 8.0. |
So, can we safely set the target to 8.0? |
Hi, yes, should be totally safe to merge this. Apps cannot work on iOS 8 without this change. |
Ok, @ndbroadbent, thanks for your quick feedback. I'm in the middle of something, it's ok for you if we release this later this week? |
Yes, no problem :) I am already just using a fork with my own changes, so I'm not in any hurry |
57f4705
to
cfcfbca
Compare
@alvaromb sorry, just another ping on this. I just rebased to the latest commit on master |
I figured this out when the build was crashing on my simulator running iOS 8.4. With help from this comment on SO.