Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add checking for null to avoid exception when .setAdUnitId is set twice #204

Merged
merged 1 commit into from
Nov 12, 2017

Conversation

almostintuitive
Copy link
Contributor

Closes #79

A two line fix that helps a lot, since all state is lost after reloading the JS code, so we can't keep track of whether this has been set or not.

@koenpunt
Copy link
Collaborator

koenpunt commented Nov 1, 2017

This will prevent a crash, but still doesn’t allow a user to update the id.
I was thinking to implement it so that when the value being set differs from the previous value a new instance is created.
But haven’t find the time to do that

@almostintuitive
Copy link
Contributor Author

almostintuitive commented Nov 1, 2017 via email

@koenpunt koenpunt merged commit 5c6d7a4 into sbugert:master Nov 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The ad unit ID can only be set once on InterstitialAd
2 participants