Svelte 5, new code format rules for frontend, some general overdue refactoring #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some code has still wrongly been deleted by the migration tool, have to restore that............ aaaaaaaaaaaaaaaa
getting stuff working first, then will cleanup where necessary
maybe i set it up wrong but it didnt seem to noticeable change file size so i dont think its worth using? idk
- Refactored the newest/oldest sorts into one function used for both: newestOldestSort() - Fixed an issue in the sort where an infinite loop could be caused when A & B both have no release date (added new case to resolve this).
this was wow many time wasted trying to figure this out but at least its a one time waste i hoppe. Removed the games filter auto removal thing in filt() because it's not _really_ necessary. We have added additional UX stuff around this since, so if this rare case ever does occur, the user has easy ways around it.
…Activity state for all uses
This change caused an issue where the poster mouseLeave event would not fire if the poster element was moved as a result of the re-sort, so some stuff has been restructured and a new call added to check if mouse is no longer over the poster to manually unactivate it.
So that we can use the setters for saving properties to localStorage after an update. $effect is not meant to be used for this, so using setters seemed like the best option, gives us a lot more control over behaviour.
Clicking it would take the user to home page without login, but they are not logged in so no data.
Created a new <Menu> component which is now used for all of our menus (the ones for the nav + the menu in AddToTagButton). Looks better now, easier to use, not sure why I ever did the global style for it, that was dumb. oh wait no im smart, it was probably because it wasn't used for the complex stuff it is now anyways shulda refactored ages agU
IRHM
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made
printWidthof 80, Always leave trailing,, use tabs.