-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
HI @mnutt, thanks for the contribution. Can we test the build against io.js on Travis-CI? |
@am11 unfortunately travis-ci doesn't yet have support for iojs, it looks like they're waiting for nvm to support it: travis-ci/travis-ci#3108 |
@mnutt, brilliant. TravisCI can wait then. :) @browniefed, if you can redo the Mac binary with these changes, I will merge this in for v2.0 (Edit: would require to delete |
@mnutt, on a separate note, can you please provide some pointers (or preferably an example of |
@am11 will get to this some time this weekend. |
+1 |
@browniefed, excellent! So this should be merged then. :) |
Thanks again @mnutt! 🎉 |
This allows node-sass to build on iojs. Tests suite passes with iojs 1.0.1 and node.js 0.10.31. Are there other node versions that should be tested as well?
Addresses #627.
One thing to note when manually rebuilding is that upstream node-gyp doesn't yet support iojs, so you need to make sure you're building using node-gyp bundled with iojs: nodejs/node#433