provide a NullAnalyticsParser if no analytics provider is given #5284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
analytics-parser-fallback
branch
from
530ac4a to
f937888
Compare
this dynamic `include` strategy seems like it could be approved upon with a more conventional dependency injecton or Strategy pattern approach. in the meanwhile, don't `NameError` on startup if no analytics provider is specified.
dlpierce
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this dynamic
includestrategy seems like it could be approved upon with a moreconventional dependency injection or Strategy pattern approach. in the meanwhile,
don't
NameErroron startup if no analytics provider is specified.@samvera/hyrax-code-reviewers